Adding ability to (un/)subscribe to topics at firebase #262 - iOS imp…

…lementation
EddyVerbruggen · Jan 17, 2017 · 0f09d14 · 0f09d14
1 parent 6a2521b
commit 0f09d14
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 4 deletions.
diff --git a/firebase.android.js b/firebase.android.js
@@ -1493,7 +1493,7 @@ firebase.deleteFile = function (arg) {
 
 firebase.subscribeToTopic = function(topicName){
   return new Promise(function (resolve, reject) {
-    try{
+    try {
 
       if (typeof(com.google.firebase.messaging) === "undefined") {
         reject("Uncomment firebase-messaging in the plugin's include.gradle first");
@@ -1506,7 +1506,7 @@ firebase.subscribeToTopic = function(topicName){
       }
 
       com.google.firebase.messaging.FirebaseMessaging.getInstance().subscribeToTopic(topicName);
-
+      resolve();
     } catch(ex){
       console.log("Error in firebase.subscribeToTopic: " + ex);
       reject(ex);
@@ -1516,7 +1516,7 @@ firebase.subscribeToTopic = function(topicName){
 
 firebase.unsubscribeFromTopic = function(topicName){
   return new Promise(function (resolve, reject) {
-    try{
+    try {
 
       if (typeof(com.google.firebase.messaging) === "undefined") {
         reject("Uncomment firebase-messaging in the plugin's include.gradle first");
@@ -1529,13 +1529,14 @@ firebase.unsubscribeFromTopic = function(topicName){
       }
 
       com.google.firebase.messaging.FirebaseMessaging.getInstance().unsubscribeFromTopic(topicName);
-
+      resolve();
     } catch(ex){
       console.log("Error in firebase.unsubscribeFromTopic: " + ex);
       reject(ex);
     }
   }); 
 }
+
 /*
 firebase.sendCrashLog = function (arg) {
   return new Promise(function (resolve, reject) {

diff --git a/firebase.ios.js b/firebase.ios.js
@@ -1569,6 +1569,42 @@ firebase.deleteFile = function (arg) {
   });
 };
 
+firebase.subscribeToTopic = function(topicName){
+  return new Promise(function (resolve, reject) {
+    try {
+
+      if (typeof(FIRMessaging) === "undefined") {
+        reject("Enable FIRMessaging in Podfile first");
+        return;
+      }
+
+      FIRMessaging.messaging().subscribeToTopic(topicName);
+      resolve();
+    } catch(ex){
+      console.log("Error in firebase.subscribeToTopic: " + ex);
+      reject(ex);
+    }
+  });
+};
+
+firebase.unsubscribeFromTopic = function(topicName){
+  return new Promise(function (resolve, reject) {
+    try {
+
+      if (typeof(FIRMessaging) === "undefined") {
+        reject("Enable FIRMessaging in Podfile first");
+        return;
+      }
+
+      FIRMessaging.messaging().unsubscribeFromTopic(topicName);
+      resolve();
+    } catch(ex){
+      console.log("Error in firebase.unsubscribeFromTopic: " + ex);
+      reject(ex);
+    }
+  });
+}
+
 /*
  firebase.sendCrashLog = function (arg) {
  return new Promise(function (resolve, reject) {