Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Commit

Permalink
#331 CI builds may file if no entitlements file exists
Browse files Browse the repository at this point in the history
  • Loading branch information
eddyverbruggen committed Mar 23, 2017
1 parent 25a5d52 commit 8b8f7ed
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 10 deletions.
19 changes: 15 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
<img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/>


## 3.11.1 (2017, March 23)

[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.11.0...3.11.1)

### SDK versions

- iOS: 3.13.x
- Android: 10.2.x

### Fixes
- [#331](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/331) CI builds may file if no entitlements file exists




## 3.11.0 (2017, March 22)

[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.10.2...3.11.0)

### SDK versions

If version numbers __changed__, clean your platform folders to avoid build errors.
Also, for Android update your Google Repository in the Android SDK manager (type `android` on the command prompt),
and for iOS do a `pod repo update` to fetch the latest versions from Cocoapods.

- iOS: 3.13.x
- Android: 10.2.x

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nativescript-plugin-firebase",
"version": "3.11.0",
"version": "3.11.1",
"description": "Fire. Base. Firebase!",
"main": "firebase",
"typings": "index.d.ts",
Expand Down
14 changes: 9 additions & 5 deletions scripts/entitlements-after-prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,16 @@ module.exports = function (logger, platformsData, projectData, hookArgs) {
return new Promise(function (resolve, reject) {
if (platform == 'ios') {
fs.exists(entitlementsFile, function (exists) {
if (!exists) return reject(); //Error("entitlementsFile: `" + entitlementsFile + "` not found"));
var dest = path.join(project, projectData.projectName + ".entitlements");
fs.copy(entitlementsFile, dest, function (error) {
if (error) return reject(error);
if (!exists) {
// no need to make noise, this is a totally valid case
resolve();
});
} else {
var dest = path.join(project, projectData.projectName + ".entitlements");
fs.copy(entitlementsFile, dest, function (error) {
if (error) return reject(error);
resolve();
});
}
})
} else {
resolve();
Expand Down

0 comments on commit 8b8f7ed

Please sign in to comment.