-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain only compatibility broken #6
Comments
Hey @jasemo, thanks for the report. Sorry this is affecting you; I largely developed this for my own use so I haven't really used it in a wide array of configurations. What's more unfortunate is that I don't have a ton of time to devote to side projects right now. :( I actually have plans for a complete rewrite, but who knows when that'll happen. Nevertheless, if I catch some free time I should be able to fix this (along with a few other things) fairly quickly. I'm sure it's an annoyance for you and others. Thanks again for reporting the issue and for using the app! |
Hi Eddie,
Thanks for the reply.. I am sorry to hear *PasswordMaker X* is in limbo at
the moment, though glad you're busy. :-)
Just so you know - your app is one of maybe three (?) in the android
marketplace (or at least the about 15 I looked at) that works and offers
the full range of passwordmaker.org options - and the *only *without other
issues and where the author has bothered with any level of concern for
design. (Seriously - the others look like something from the 90s.) - I say
that only to explain that yours would be one app I'd happily drop money on.
- If only that pesky full-stop was fixed.
BTW, if you do get round to it, you might find a number of other complaints
go away - I noticed one about a lack of compatibility with the web-based
generator and other apps. For me compatibility was perfect if I simply
added a leading "." in the comparison generator. - I'm guessing they were
doing the same as me and just didn't notice the period at the start of the
"using text" area.
Anyway thanks for your reply and best of luck with your other endeavors -
here's hoping you get time to work on this again sometime soon.
Regards,
Jason M-O
…On Fri, 21 Jul 2017 at 02:34 Eddie Ringle ***@***.***> wrote:
Hey @jasemo <https://github.com/jasemo>, thanks for the report. Sorry
this is affecting you; I largely developed this for my own use so I haven't
really used it in a wide array of configurations. What's more unfortunate
is that I don't have a ton of time to devote to side projects right now. :(
I actually have plans for a complete rewrite, but who knows when that'll
happen. Nevertheless, if I catch some free time I should be able to fix
this (along with a few other things) fairly quickly. I'm sure it's an
annoyance for you and others.
Thanks again for reporting the issue and for using the app!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ac4_OERiJ8gSX9kZ1g4PpzfNJ6sQaI5rks5sP4F-gaJpZM4Ocyzm>
.
|
Hi Eddie, this is really bugging me, too. No need for a rewrite, just a small fix: Basically all that you would have to change is to use the Input Text as is, without assuming it's a URL. That is, you'd just have to revert commit 8867ba3 -- or, even better, bail out of that code if the Input Text doesn't contain a dot. Best, |
Hi Márton ,
Awesome to know I wasn't the only one that found this. Found the same issue
with a number of similar apps too. Hope someone can work out a fix.
Please let me know if you do.
Best regards,
Jason M-O
…On Mon, 4 Mar 2019 at 17:03 marton78 ***@***.***> wrote:
Hi Eddie,
this is really bugging me, too. Basically all that you would have to
change is to use the *Input Text* as is, without assuming it's a URL.
That is, I assume you'd just have to revert commit 8867ba3
<8867ba3>
.
If you really lack the time to tackle this issue, I might be able to send
you a pull request, but I'd need to understand *why* you're parsing the *Input
Text* as URL.
Best,
Márton
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ac4_OEB69cUO0jOuMJXKPt0HyuLv5WtCks5vTLccgaJpZM4Ocyzm>
.
|
The app prefixes the entry text with a period when only the domain url component is selected: so "google" becomes ".google". This breaks compatibility with the chrome extension, other passwordmaker.org apps, and makes it useless for generating consistent "real life" passwords that do not derive from a url format
The text was updated successfully, but these errors were encountered: