Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

docs: #8671 Discord channel readme improvements #8686

Merged
merged 3 commits into from
Feb 27, 2024
Merged

docs: #8671 Discord channel readme improvements #8686

merged 3 commits into from
Feb 27, 2024

Conversation

LeaDevelop
Copy link
Contributor

closes #ISSUE-NO

What does this PR do?

Resolves issue #8671

  • pointed to "Browse Channels" menu option and explained what it offers
  • text channels improvements, channels listed based on Discord's template flow
    • added missing channels and it's descriptions
    • removed "hackatons" channels
    • moved bot-chat channel to "community discussions" section
  • bonus content, introduced voice channel explanation

Description of the task to be completed?

  • Review proposed changes and evaluate whether the fit in
  • Suggest any future improvements on the topic of discord's readme and propose future improvements
    • Do you feel each channel being explained is still necessary or could we introduce that into Browse Channels discord's feature in future perhaps

How can this be manually tested?

Sync pull request and review it locally.

Any background context you want to provide?

Is there any relevant issue to this PR?

#8669
#8671

Screenshots (if appropriate)

Questions and considerations for the reviewer of PR

  • bonus content, feel free to disregard, if you feel not fitting:
    bbe57a7

@LeaDevelop
#8671 fix: Pointed to "Browse Channels" menu option and explained wha…
59084e4 
…t it offers.
@LeaDevelop
#8671 docs: introduced voice channels explanation.
bbe57a7 
- Bonus content, feel free to disregard, if you feel not fitting.
@LeaDevelop
#8671 fix: text channels improvements, channels listed based on Disco…
cf58bca 
…rd's template flow

- added missing channels and it's descriptions
- removed "hackatons" channels
- moved bot-chat channel to "community discussions" section
github-actions[bot]
github-actions bot reviewed Feb 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@LeaDevelop
Copy link
Contributor Author

@eddiejaoude is there any specific flow you got here, that you go through PR's on weekly basis, or we got to be proactive and poke?

@eddiejaoude
Copy link
Member

@eddiejaoude is there any specific flow you got here, that you go through PR's on weekly basis, or we got to be proactive and poke?

Hey Lea, sorry I get behind on notifications because I get so many. Plus the maintainers get busy with other things also. So a nudge here and/or on in Discord is a good idea. Thank you 👍

eddiejaoude
eddiejaoude approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 👍

@eddiejaoude eddiejaoude merged commit d62c4db into EddieHubCommunity:main Feb 27, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eddiejaoude eddiejaoude eddiejaoude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaDevelop @eddiejaoude