-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add React hook form validations #9835
base: main
Are you sure you want to change the base?
Conversation
@eddiejaoude let me know what you think when you're available! |
date, | ||
isGoal, | ||
dateFormat, | ||
title: milestoneWatch[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way not to use position [0]
? Because I can see this creating bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't get what you mean here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean using [0]
seems strange to me? why 0
, for example it causes confusion, why not 1
or 2
Looks good (I didn't test it yet though) |
I'll make the updates in a day or two a bit busy |
Co-authored-by: Eddie Jaoude <[email protected]>
Busy this week. Will make the change as soon as i get some time |
Co-authored-by: sital002 <[email protected]>
@eddiejaoude can you check the PR once, let me know if we should go ahead and implement it in the other forms |
@eddiejaoude just wanted to ping you incase this slipped through the cracks. I have added some comments , let me know what you think |
Thanks @ChinmayMhatre - Let's also check with the other maintainers. Could you check inline comments |
Co-authored-by: Eddie Jaoude <[email protected]>
Fixes Issue
Closes #8031
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers