Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: sandramsc #6113

Merged
merged 7 commits into from
Apr 16, 2023
Merged

data: sandramsc #6113

merged 7 commits into from
Apr 16, 2023

Conversation

sandramsc
Copy link
Member

@sandramsc sandramsc commented Apr 15, 2023

fix json syntax error at "Web3"

updated structure & added new milestone
fix json syntax error at "Web3"
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Apr 15, 2023
json syntax fix -#3
@github-actions github-actions bot added large Pull request with more than 30 changed lines and removed medium Pull request with changed lines between 10 and 30 labels Apr 15, 2023
json syntax fix - #1
testing json syntax error source
json syntax fix -#6
@sandramsc
Copy link
Member Author

sandramsc commented Apr 15, 2023

not sure why the JSON check keeps failing:

I restructured and edited the json multiple times to debug where this error is, even by copying and pasting Eddies's json into mine (passed all checks) -- then replacing it with my data which failed 3 more times...

}
"icon": "FaLinkedin",
"color": "#0000FF"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comma

Suggested change
},
}

@SaraJaoude
Copy link
Member

not sure why the JSON check keeps failing:

I restructured and edited the json multiple times to debug where this error is, even by copying and pasting Eddies's json into mine (passed all checks) -- then replacing it with my data which failed 3 more times...

I copied/pasted the file into jsonlint.com and hopefully the inline comment I have made resolves this. We should be able to merge your PR once you change the information back to your own name/bio

JSON syntax fix
@sandramsc
Copy link
Member Author

not sure why the JSON check keeps failing:
I restructured and edited the json multiple times to debug where this error is, even by copying and pasting Eddies's json into mine (passed all checks) -- then replacing it with my data which failed 3 more times...

I copied/pasted the file into jsonlint.com and hopefully the inline comment I have made resolves this. We should be able to merge your PR once you change the information back to your own name/bio

Thanks @SaraJaoude!

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SaraJaoude SaraJaoude merged commit 88bcba2 into EddieHubCommunity:main Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants