fix: memoize userdata prop passed to user profile component #5570
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
the
medium
| userData.tags, | ||
| userData.username, | ||
| ] | ||
| ); |
There was a problem hiding this comment.
But none of the user data changes, is this required?
There was a problem hiding this comment.
It is not because of user data. We are just extracting only the required user information for userProfile component.
Using memo to avoid assignment of new address on every re-render.
It is used to remove reviews, testimonials ... all the tabs data.
There was a problem hiding this comment.
thank you for expelling @psavan1655 👍
There was a problem hiding this comment.
Welcome @eddiejaoude .
Btw when are you planning to implement the user add by form feature? As i want to join with you during that.
There was a problem hiding this comment.
Yes I started on that 👍 I should push what I have so far to a draft PR. I will try to do that this weekend
There was a problem hiding this comment.
Can you refer me other open source react related projects? with some intermediate-experienced level codebsae?
I would like to contribute more.
|
Thank you for the contribution, as this code is growing for a feature that is not used, I have created a PR #5742 to remove the sorting so this PR is no longer needed. Sorry for any inconvenience, I didn't think of this sooner |
Fixes Issue
Closes #5535
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers