-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[FEATURE] fixed tags duplicate issue in discovery page due to case sensitivity #3721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Welcome @rwiteshbera! Thank you so much for your first pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea, but I think it would be best to happen on the server side here https://github.com/EddieHubCommunity/LinkFree/blob/main/pages/api/discover/tags.js
I think to keep things super simple we could lowercase all tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the backend part stats are still set differently reactjs
, and react js
so if I search for reactjs
I will not get results for react js
so I think putting the data in the server in the right format seems a better option
Hi, @eddiejaoude, I guess it would be beneficial to reorganize and reformat the current data by converting it to a standardized format, such as making all letters lowercase and removing any special characters or spaces. |
I think then we are trying to build a search engine, which we don't want to do. There is an issue to improve the search using libraries/tools that focus on search #900 |
Thank @rwiteshbera for the improvement, the tags do looks better when listed on the Discover page, howeer then the results don't match when a tag is clicked and searched. This could be solved when performing the search applying the same logic to the users tag, but then we would need to apply the same for the users profile tag list also. But really we should not be changing how the tags are displayed on their profiles, but improving the search results. Please see #900 as mentioned previously |
Could you please provide me with some screenshots so I can proceed with my local setup, as it is currently functioning properly? In my case, both results look the same when I am searching or clicking on the user's tag. |
How does this affect the search? For example instead of |
Hi, @eddiejaoude , I am getting correct results here. |
Thank you for your contribution. This recently got removed from the Discovery page. So I will close this PR. We are creating more issues, so keep an eye on there for more |
Welcome @rwiteshbera! Thank you so much for your first pull request! |
Closes #3604
Fixes Issue
Fixed tags duplicate issues in discovery page due to case sensitivity
Before:
JavaScript(10), javascript(5), Javascript(2)
After:
javascript(17)
Changes proposed
While displaying the tags, I have added a snippet that will do the following task with all the tags:
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
Please let me know if there are any changes or updates needed before it can be merged. I am open to suggestions and feedback to ensure that the code is of the highest quality.