Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Krishna profile update - milestore added #3685

Closed

Conversation

Krishnapro
Copy link
Member

@Krishnapro Krishnapro commented Jan 19, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Conventional Changelog Action and others added 3 commits January 19, 2023 17:41
@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 waiting-for-reviewers ✍ chore: profile This label will be added on PR with request of Data json addition labels Jan 19, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated files CHANGELOG.md and package-lock.json should not be part of your Pull Request.

These have probably happened because you are running the GitHub Actions in your fork.

Please disable GitHub Actions running in your fork to avoid these files being generated in your Pull Request in the future.

Please revert these files. This can be done with the git checkout command for each file if you are working in a branch, for example...

git checkout main -- CHANGELOG.md
git checkout main -- package-lock.json

Copy link
Member

@Tejender1521 Tejender1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete all the files except your data file.

@kumarsonsoff3
Copy link
Member

Just delete all the files except your data file.

Need not to delete the files, you can just follow the steps SaraJaoude mentioned above. If you need any other help, you can refer this video by Eddie. https://youtu.be/YUHS5Ana7Jw

@Krishnapro
Copy link
Member Author

I mesh with all the changes with conflict. so don't mind I'm closing this pull request and will open a fresh one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants