Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:rayeesrather99 #3677

Merged

Conversation

rayeesrather99
Copy link
Member

@rayeesrather99 rayeesrather99 commented Jan 19, 2023

Done

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Jan 19, 2023
@github-actions
Copy link
Contributor

Welcome @rayeesrather99! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Jan 19, 2023
Copy link
Member

@dan-mba dan-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the JSON problem, add a comma at the end of lines 6, 12, 17, & 22

@rayeesrather99
Copy link
Member Author

Added commas at the end of line of 6, 12, 17, & 22 .

Copy link
Member

@dan-mba dan-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you want the LinkedIn icon (FaLinkedin) and the GitHub icon (FaGithub) for those links instead of the Instagram icon

@rayeesrather99
Copy link
Member Author

changed the fa linkedin icon . now it's fine.

Copy link
Member

@dan-mba dan-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SaraJaoude SaraJaoude merged commit 5e08a4c into EddieHubCommunity:main Jan 19, 2023
@rayeesrather99
Copy link
Member Author

Thank u : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants