-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
data: theranamuskan #3671
data: theranamuskan #3671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Welcome @theranamuskan! Thank you so much for your first pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a missing comma in the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except a comma [,] on line 28
Co-authored-by: Chinmay Mhatre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename your filename to your username.json
, else some feature may not work for you!
It should be theranamuskan.json
. Let us know if you need any help. 🛠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change your file name to your github username,
theranamuskan.json
data/theranamuskan.json
Outdated
"icon": "FaGithub" | ||
} | ||
], | ||
"links": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have duplicate code. delete lines 27 to 39
Welcome @theranamuskan! Thank you so much for your first pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @theranamuskan, a few more changes are required, then it should be good to go.
Co-authored-by: Priyanshu kumawat <[email protected]>
Co-authored-by: Priyanshu kumawat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good, Thanks! 🎉
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers