Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: theranamuskan #3671

Merged

Conversation

theranamuskan
Copy link
Contributor

@theranamuskan theranamuskan commented Jan 19, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Jan 19, 2023
@github-actions
Copy link
Contributor

Welcome @theranamuskan! Thank you so much for your first pull request!

@github-actions github-actions bot added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jan 19, 2023
Copy link
Member

@ChinmayMhatre ChinmayMhatre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a missing comma in the file

data/RanaMuskan.json Outdated Show resolved Hide resolved
Copy link
Member

@Tejender1521 Tejender1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except a comma [,] on line 28

@schmelto schmelto changed the title data:RanaMuskan data: RanaMuskan Jan 19, 2023
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your filename to your username.json, else some feature may not work for you!

It should be theranamuskan.json. Let us know if you need any help. 🛠

@theranamuskan theranamuskan changed the title data: RanaMuskan adding theranamuskan.json Jan 26, 2023
@theranamuskan theranamuskan changed the title adding theranamuskan.json data: theranamuskan Jan 26, 2023
Copy link
Member

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change your file name to your github username,
theranamuskan.json

data/RanaMuskan.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the LGTM label Jan 29, 2023
"icon": "FaGithub"
}
],
"links": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have duplicate code. delete lines 27 to 39

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Welcome @theranamuskan! Thank you so much for your first pull request!

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @theranamuskan, a few more changes are required, then it should be good to go.

data/theranamuskan.json Outdated Show resolved Hide resolved
data/theranamuskan.json Outdated Show resolved Hide resolved
SaraJaoude and others added 2 commits February 9, 2023 13:49
Co-authored-by: Priyanshu kumawat <[email protected]>
Co-authored-by: Priyanshu kumawat <[email protected]>
@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 and removed large Pull request with more than 30 changed lines labels Feb 9, 2023
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, Thanks! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants