Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:Madhavi210 #3623

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Conversation

Madhavi210
Copy link
Contributor

@Madhavi210 Madhavi210 commented Jan 18, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Jan 18, 2023
@github-actions
Copy link
Contributor

Welcome @Madhavi210! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Jan 18, 2023
{
"name": "Follow me on LinkedIn",
"url": "https://www.linkedin.com/in/madhavi-joshi-0b3228239/",
"icon": "FaLinkedIn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linkedin icon name should be FaLinkedin

Suggested change
"icon": "FaLinkedIn"
"icon": "FaLinkedin"

Copy link
Member

@ChinmayMhatre ChinmayMhatre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the commas as suggested

data/Madhavi210.json Outdated Show resolved Hide resolved
data/Madhavi210.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thank you for your contribution! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants