alignment of headings

[rohinish404]

Solves the issue #3596 i created

Fixes Issue

fix #3596

Changes proposed

Aligned the text properly. Attaaching a ss below to show proposed changes.

Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• My change requires changes to the documentation.
• I have updated the documentation accordingly.
• All new and existing tests passed.
• This PR does not contain plagiarized content.
• The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

[github-actions]

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[Aadarsh805]

removing the justify-between caused this on desktop [ignore, I ran the code in a branch with old code]

[rohinish404]

But its looking perfectly fine when i open this in gitpod

[Aadarsh805]

removing the justify-between caused this on desktop

Oh wait, i ran in wrong branch ig
totally mb, didn't even notice the wrong button

[Aadarsh805]

@rohinish404 Hey Rohinish, could you try the suggested changes

[rohinish404]

@Aadarsh805 which changes??

[Aadarsh805]

@Aadarsh805 which changes??

The alignment error that is being caused by the margin bottom

[rohinish404]

You are talking about the different margin bottom under the random profiles and the popular profiles right??

[Aadarsh805]

You are talking about the different margin bottom under the random profiles and the popular profiles right??

No I'm talking about the mb-4 on H2 and not the icon, so because of one of them having the margin bottom they are not aligned

[rohinish404]

Done..how it's looking now??

[Aadarsh805]

All good now

[eddiejaoude]

Please add a before and after screenshot

[rohinish404]

Yeah sure!!
Here's how this was looking before-

213004999-73a9a30d-422d-4ff2-af80-5b8e14936dae.mov

And now it's looking-

Screen.Recording.2023-01-21.at.11.59.42.AM.mov

[Aadarsh805]

add screenshot too, these video sometimes don't play, like rn one of them is not working on mine

[rohinish404]

sure!!
Before-

After-

[Avi-88]

Hi, just sharing my thought, wouldn't it look better if the headings are center aligned for smaller screens instead of how it looks currently ?

[rohinish404]

@Avi-88 yeah but the headings below and above it are left aligned so it being cener aligned is disturbing the whole flow of the page.

[Avi-88]

I was talking about making all the headings center aligned for smaller screens , what do you think about this ?

[rohinish404]

Thats also a good idea..i was thinking the same before making this pr. @Aadarsh805 what do u think about this?

[Aadarsh805]

Thats also a good idea..i was thinking the same before making this pr. @Aadarsh805 what do u think about this?

Yep it'd be better to have all center aligned actually

left aligned looks weird on mobile

[rohinish404]

Okay, should i make the changes?

[Aadarsh805]

Okay, should i make the changes?

Yeah go ahead

[eddiejaoude]

Great collaboration everyone 👍 I think the improvements are a step in the right direction, the refresh icon doesn't need to go to it's own line when on mobile 👍

[Avi-88]

Glad i could, help good luck with the PR @rohinish404 👍

[rohinish404]

Great collaboration everyone 👍 I think the improvements are a step in the right direction, the refresh icon doesn't need to go to it's own line when on mobile 👍

Then i think we should go with all the headings being left aligned or if we want all the heading to be centered and the refresh icon to stay in the same line..it's looking like this👇
Which one will look better??

[Aadarsh805]

Great collaboration everyone +1 I think the improvements are a step in the right direction, the refresh icon doesn't need to go to it's own line when on mobile +1

Then i think we should go with all the headings being left aligned or if we want all the heading to be centered and the refresh icon to stay in the same line..it's looking like thispoint_down Which one will look better??

Yeah this one's good

[rohinish404]

Glad i could, help good luck with the PR @rohinish404 👍

Thank you for bringing a fresh perspective🙂

[rohinish404]

Great collaboration everyone +1 I think the improvements are a step in the right direction, the refresh icon doesn't need to go to it's own line when on mobile +1

Then i think we should go with all the headings being left aligned or if we want all the heading to be centered and the refresh icon to stay in the same line..it's looking like thispoint_down Which one will look better??

Yeah this one's good

okay, i'll commit the changes.

[rohinish404]

How it's looking now??

[Aadarsh805]

How it's looking now??

Looks great to me

[eddiejaoude]

Thank you 👍