Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Data:Greenchapeljohn #3566

Merged

Conversation

johngreen-dev
Copy link
Member

@johngreen-dev johngreen-dev commented Jan 16, 2023

Changes proposed

Adding JohnGreenDev Linkfree Data file

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Conventional Changelog Action and others added 3 commits January 16, 2023 20:33
Merge new release into main
Initial version of johngreendev link free file
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added large Pull request with more than 30 changed lines ✍ chore: profile This label will be added on PR with request of Data json addition labels Jan 16, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep your profile changes only and revert the other changes.
I think this can be fixed by updating your branch. Any help, let us know. 🙂

@johngreen-dev
Copy link
Member Author

My commit only contains the one file change.
The other change has been done by the github action ( I assume setup in the project ?)

@johngreen-dev
Copy link
Member Author

Think the above has now been succeeded with main

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your file to username.json, else some features may not work for you.

It should be greenchapeljohn.json. 🛠

@github-actions github-actions bot added the LGTM label Jan 18, 2023
@johngreen-dev
Copy link
Member Author

File Is now renamed

@johngreen-dev
Copy link
Member Author

Sure, I updated that, did plan to add them later but I can stick the object back in once I have some milestones written to go in it.

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 🎉

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SaraJaoude SaraJaoude merged commit f21e40a into EddieHubCommunity:main Jan 19, 2023
@eddiejaoude
Copy link
Member

My commit only contains the one file change.
The other change has been done by the github action ( I assume setup in the project ?)

@greenchapeljohn thanks for fixing 👍 it looks like the GitHub Actions are running on your fork, these should not be running on the fork (they should be off by default on a fork)

@johngreen-dev
Copy link
Member Author

Will take a look and see why they are switched on. I did have an old fork from a while back when I did some doc additions, probably had it enabled from then.

@eddiejaoude
Copy link
Member

@greenchapeljohn ah maybe, let us know how it goes or if we can help with anything 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants