Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:iqrafirdose #3550

Merged
merged 7 commits into from
Jan 16, 2023
Merged

data:iqrafirdose #3550

merged 7 commits into from
Jan 16, 2023

Conversation

iqrafirdose
Copy link
Contributor

@iqrafirdose iqrafirdose commented Jan 16, 2023 •
edited by gitpod-io bot
Loading

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

github-actions[bot]
github-actions bot reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Jan 16, 2023
@github-actions
Copy link
Contributor

Welcome @iqrafirdose! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Jan 16, 2023
maheshkasabe
maheshkasabe previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@maheshkasabe maheshkasabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Thanks for the contribution !

arpitghura
arpitghura suggested changes Jan 16, 2023
View reviewed changes
data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
@arpitghura arpitghura mentioned this pull request Jan 16, 2023
Closed
6 tasks
Pradumnasaraf
Pradumnasaraf suggested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

The file still needs some JSON syntax correction. I have requested the change. If you need any help feel free to ask

data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
@iqrafirdose
Copy link
Contributor Author

Hey,

The file still needs some JSON syntax correction. I have requested the change. If you need any help feel free to ask

I did the changes that you suggested and it again fails in JSON syntax.

arpitghura
arpitghura suggested changes Jan 16, 2023
View reviewed changes
data/iqrafirdose.json Outdated
"avatar": "https://github.com/iqrafirdose.png",
"tags": ["Developer","Open Source", "Web dev", "Blogger"],
"socials": [
{ "icon": "FaTwitter", "url": "https://twitter.com/iqra_firdose" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add , at the end

Suggested change
{ "icon": "FaTwitter", "url": "https://twitter.com/iqra_firdose" }
{ "icon": "FaTwitter", "url": "https://twitter.com/iqra_firdose" },

data/iqrafirdose.json Outdated Show resolved Hide resolved
data/iqrafirdose.json Outdated Show resolved Hide resolved
arpitghura
arpitghura reviewed Jan 16, 2023
View reviewed changes
data/iqrafirdose.json Outdated Show resolved Hide resolved
arpitghura
arpitghura reviewed Jan 16, 2023
View reviewed changes
data/iqrafirdose.json Outdated Show resolved Hide resolved
arpitghura
arpitghura previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@arpitghura arpitghura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines and rest all things good.

@Pradumnasaraf
Copy link
Contributor

Remove these lines and rest all things good.

There is no need to request for removing extra lines. Action will do after the merge. Thank you

@iqrafirdose
Copy link
Contributor Author

I hope now it's works

Pradumnasaraf
Pradumnasaraf approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thank you for your contribution! 🎉

@Pradumnasaraf Pradumnasaraf merged commit 7ac462e into EddieHubCommunity:main Jan 16, 2023
@iqrafirdose
Copy link
Contributor Author

Hello, When I can able to see my Eddiehub linkfree?

@Pradumnasaraf
Copy link
Contributor

Hello, When I can able to see my Eddiehub linkfree?

Its already live at https://linkfree.eddiehub.io/iqrafirdose. If you are still unable to see it, do let's know.

@gptkrsh gptkrsh mentioned this pull request Jun 1, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 3, 2023
Open
@gptkrsh gptkrsh mentioned this pull request Jun 6, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2023
Open
This was referenced Jun 15, 2023
Open
Open
This was referenced Jun 28, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

@maheshkasabe maheshkasabe maheshkasabe left review comments

@arpitghura arpitghura arpitghura left review comments

Assignees
No one assigned
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iqrafirdose @Pradumnasaraf @arpitghura @maheshkasabe