Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:underager #3475

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Conversation

underager
Copy link
Contributor

@underager underager commented Jan 15, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • [X ] My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • [X ] All new and existing tests passed.
  • [X ] This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Jan 15, 2023
@github-actions
Copy link
Contributor

Welcome @underager! Thank you so much for your first pull request!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added waiting-for-reviewers ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Jan 15, 2023
{
"name": "Github",
"url": "https://github.com",
"icon": "faGithub"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon should be FaGithub

{
"name": "LinkedIn",
"url": "https://www.linkedin.com/in/atul-nirbhavane-554067b4/",
"icon": "faLinkedin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this should be FaLinkedin

Copy link
Member

@Tejender1521 Tejender1521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide your Github profile URL and use FaGithub icon

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants