Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: where to put links confusion #2593

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Conversation

mohit1607
Copy link
Contributor

@mohit1607 mohit1607 commented Jan 2, 2023

The json object for only links is updated to the whole json of a profile, so that no furher confusion about the structure of json happen.

Fixes Issue

Quckstart improvement - explain json structure #2538

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot (5732)

Note to reviewers

The json object for only links is updated to the whole json of a profile, so that no furher confusion about the structure of json happen.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the small Pull request with less than 10 changed lines label Jan 2, 2023
a small fix that is showing invalid Json object
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🚀

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddiejaoude eddiejaoude merged commit 9c8d2bb into EddieHubCommunity:main Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text undefined ✨ goal: improvement undefined small Pull request with less than 10 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants