This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Profile Addition #2532
Merged
Profile Addition #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of new profile mohit1607.
Merged the Branch created for adding a profile
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
medium
eddiejaoude
reviewed
Dec 29, 2022
data/mohit1607.json
Outdated
| "tags": ["javascript", "typescript", "react.js", "node.js", "mongodb", "fullstack"], | ||
| "socials": [ | ||
| { "icon": "twitter", "url": "https://twitter.com/ashliya_mohit" }, | ||
| { "icon": "github", "url": "https://github.com/mohit1607" } |
There was a problem hiding this comment.
These are not icons, please use icons available, for example FaTwitter https://linkfree.eddiehub.io/icons
eddiejaoude
suggested changes
Dec 29, 2022
Resolved the issue using the appropriate icons in socials array.
|
Hi Eddie thanks for reviewing my profile and Now I look forward to solve more issues. |
Pradumnasaraf
approved these changes
Dec 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of new profile mohit1607.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers