Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

adding profile to public/data #1803

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

ahmedsilat44
Copy link
Contributor

@ahmedsilat44 ahmedsilat44 commented Sep 26, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Sep 26, 2022
@github-actions
Copy link
Contributor

Welcome @ahmedsilat44! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Sep 26, 2022
Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

Your suggested changes looking good to me.


Summary: 👌 This code looks good

@ahmedsilat44
Copy link
Contributor Author

@Panquesito7 Hey, I made the changes. Pls review it and tell me if it looks good. Thanks 😄

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for contributing! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants