Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The temp settings dont want to remember #19

Open
sansansansansansan opened this issue Sep 23, 2023 · 3 comments
Open

The temp settings dont want to remember #19

sansansansansansan opened this issue Sep 23, 2023 · 3 comments

Comments

@sansansansansansan
Copy link

The temp settings dont want to remember. I set the 350 degrees, then Return. And nothing - the temperature settings as default...

@sysytwl
Copy link

sysytwl commented Sep 28, 2023

yes, i got the same problem

@dexter323i
Copy link

This part causes it at line 612 in Thermostat() function:

if (SetTemp != DefaultTemp) {
    DefaultTemp = SetTemp;  // 把设置里面的默认温度也修改了
    update_default_temp_EEPROM();
}

When user finishes setting up things, and exists to main screen, then update_EEPROM() is called, which saves everything correctly. Even DefaultTemp too!
Then normal operation starts, Thermostat() called from loop, but SetTemp won't be equal to DefaultTemp, so DefaultTemp is overwitten with SetTemp, then it is also saved in eeprom. Which is wrong, because it overwrites user's previous DefaultTemp modification.

I don't know why this part is even here. What is the intended reason of it?

@dexter323i
Copy link

Update: now I get it what is the reason of this part: When the user changes temp with Plus and Minus buttons, it is stored as Deafult temp, which shifts the Boost temp too.
I made a pull request to fix the original issue.

vortigont added a commit to vortigont/ESPIron-PTS200 that referenced this issue May 13, 2024
…temperature

Setting -> Temperature -> use last temp

Checkbox controls if last used work temperature should be saved in NVS and restored on power on.
If disabled (default) then work temperature from settings will be used on power on.
If enabled, then each time work temp is changed, it will be saved/restored later

ref issue:
Eddddddddy/Songguo-PTS200#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants