Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements for exporting shapefiles #140

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Refinements for exporting shapefiles #140

merged 2 commits into from
Nov 22, 2024

Conversation

pollardld
Copy link
Member

This pull request includes several changes to enhance the user experience and improve the functionality of the Landmapper application. The updates include modifications to the CSS, JavaScript, HTML templates, and a Python view function.

Enhancements to user experience and functionality:

  • landmapper/app/static/landmapper/css/report.css: Updated the .action-wrap class to handle both .disabled and :disabled states by changing the background and opacity, and disabling pointer events.

  • landmapper/app/static/landmapper/js/report.js: Added data-property-name attribute to the export layer button and used it for the download filename instead of data-property-id. [1] [2]

  • landmapper/app/templates/landmapper/report/report-overview.html:

    • Added data-property-name attribute to the export layer button and updated the title for better accessibility.
    • Included a login link for users who are not authenticated, prompting them to log in to download the shape file. [1] [2] [3]
  • landmapper/app/views.py: Modified the export_layer view function to use the sanitized property name for the shapefile export directory instead of the property primary key.

@pollardld pollardld self-assigned this Nov 22, 2024
@pollardld pollardld merged commit f05ee69 into main Nov 22, 2024
2 checks passed
@pollardld pollardld deleted the property2shp branch November 22, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant