Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply @njit to interp and mlinterp #114

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Apply @njit to interp and mlinterp #114

merged 4 commits into from
Mar 21, 2024

Conversation

oyamad
Copy link
Contributor

@oyamad oyamad commented Mar 21, 2024

interp and mlinterp now return something other than None.

I do not know what this line was doing:

See the change in 7003f0f

@albop
Copy link
Member

albop commented Mar 21, 2024

@oyamad : Had to go back to an older version of numba to be reminded of what was going on.
The code in @generated_jit was called with the type of its arguments, same as @overload. But the treatment of *args was different. With @generated_jit , the type of args was for instance (UniTuple(Array(float64, 1, 'C', False, aligned=True), 3),) , which includes the type of a tuple of the types passed as arguments. With overload you just get a tuple of the types of each components of args. So all perfectly logical and I can merge this PR.

@albop albop merged commit 2d20da5 into EconForge:master Mar 21, 2024
@oyamad oyamad deleted the overload branch March 22, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants