Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added component label to some resources to disambiguate selectors #1294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbarbero
Copy link
Member

We are using the same labels set for both the server deployment and the elasticsearch statefulset. Kubectl CLI is confuses the matching pods when doing requests on deployments or statefulset as it probably uses the selector to find matching pods:

$ oc logs -n open-vsx-org deploy/open-vsx-org-production --tail=1
Found 7 pods, using pod/elasticsearch-production-es-default-2

This may also cause confuse the cluster, even though I have no proof of that.

This cannot be deployed as is as the labels of pod templates in deployments and statefulsets cannot be updated once created. I'll provide the steps shortly

@mbarbero
Copy link
Member Author

The only way to deploy this change is to delete the old previous resources. Below the instruction for staging, needs to be replicated for prod. Note that this will introduce downtime:

  1. delete the elasticsearch cluster and the open-vsx deployment
$ oc delete -n open-vsx elasticsearch/elasticsearch-staging deployment/open-vsx-org-staging
  1. run a deployment job from laptop
./gen-deployment.sh staging <image> | kubectl apply -f -
  1. verify and profit.

@kineticsquid
Copy link
Contributor

@mbarbero What's next with this one?

@mbarbero
Copy link
Member Author

It's up to the ops team to decide when then want to to that.

@kineticsquid
Copy link
Contributor

@amvanbaren Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants