Update to the latest template #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Poirier <[email protected]>
ericpoirier
requested review from
chrisguindon,
autumnfound,
oliviergoulet5 and
ZacharySabourin
_includes/nav_more.html
Outdated
| </div> | ||
| </div> | ||
| <script async src="https://cse.google.com/cse.js?cx=011805775785170369411:p3ec0igo0qq"></script> | ||
| <gcse:searchbox-only gname="main" resultsUrl="https://www.eclipse.org/home/search.php"></gcse:searchbox-only> |
There was a problem hiding this comment.
I was expecting the new version to not include cse.js
Signed-off-by: Eric Poirier <[email protected]>
_sass/jekyll-theme-eclipsefdn.scss
Outdated
| @@ -20,3 +20,15 @@ td { | |||
| border: 1px solid #ebebeb; | |||
| } | |||
|
|
|||
| #custom-search-form { | |||
There was a problem hiding this comment.
Why the need of custom css for the search? Why do we need this here but not on eclipse.org?
There was a problem hiding this comment.
I'm adding custom CSS because on eclipse.org we rely on styles coming from Google when using their search widget. Since we are now using a simple form here, we need to add some extra CSS.
There was a problem hiding this comment.
The whole point of this transition is to not include files from google.
I think this is something we need to fix in solstice assets not here.
Signed-off-by: Eric Poirier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Poirier [email protected]