Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add repo stats badges #6697

Merged
merged 24 commits into from
Mar 15, 2022

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Feb 6, 2022

What does this PR do?

Add info | Improve repo

For resources

Description

Completes a bit more the counters about the repository using badges provided by the https://img.shields.io service:

  • Forks count
  • Stargazers count
  • Watchers count
  • Repository size in bytes
  • Contributors count
  • Sponsors count
  • Issues open by labels
  • Pull Request open/merged by labels
  • Website link badge
  • Hacktoberfest badge (commented)

A preview about GHP rendering: https://davorpa.github.io/free-programming-books/

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

pointing to main branch download
- link points to sponsorized profile page
- render version is placed at new line.
- With social balloon style
- link points to its filter: open & "help wanted"
- in a new line
- by filter: open, merged, "help wanted"
- using social balloon style
- linked with its own query filter
- in a new line
- link points to the github.io version of the repo
@davorpa davorpa self-assigned this Feb 6, 2022
@davorpa davorpa added the 👥 discussion This Repo is guided by its community! Let's talk! label Feb 6, 2022
@davorpa davorpa marked this pull request as ready for review February 6, 2022 12:42
@davorpa davorpa added the 👀 Needs Review Is this really a good resource? Reviews requested. label Feb 6, 2022
@davorpa
Copy link
Member Author

davorpa commented Feb 6, 2022

NOTE

Needs consensuate what are usefull (see pending tasks)

@LuigiImVector
Copy link
Member

I like the badges regarding the number of forks, stars and watchers but I think they should be added only if the stats are removed from the (maybe also adding the number of contributions, commits and merged PRs):

The list was moved to GitHub by Victor Felder for collaborative updating and maintenance. It has grown to become one of [GitHub's most popular repositories](https://octoverse.github.com/), with 221,000+ stars, 6,900+ commits, 1,900+ contributors, and 47,100+ forks.
There would be too much redundancy of information otherwise.

I find instead useful badges regarding the "help wanted", would help new contributors to understand what to do.

For the style: the same color should be used for everything (gray and blue/light gray, for example) and the size should be the same.

@davorpa
Copy link
Member Author

davorpa commented Feb 6, 2022

I like the badges regarding the number of forks, stars and watchers but I think they should be added only if the stats are removed from the (maybe also adding the number of contributions, commits and merged PRs):

The list was moved to GitHub by Victor Felder for collaborative updating and maintenance. It has grown to become one of [GitHub's most popular repositories](https://octoverse.github.com/), with 221,000+ stars, 6,900+ commits, 1,900+ contributors, and 47,100+ forks.

There would be too much redundancy of information otherwise.

I agree too in pro of automatize things in a future 🚀 but the text will be lost for blind users using readable browsers like JAWS

@LuigiImVector
Copy link
Member

but the text will be lost for blind users using readable browsers like JAWS

maybe these stats can read them from the official github buttons, although it may be slower and more difficult, idk

@eshellman
Copy link
Collaborator

looks very cluttered. mostly redundant, but I wouldn't object to surfacing the sponsors.

README.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member

CleanMachine1 commented Feb 6, 2022

Personally, I only like

  • The license
  • stars forks and watchers
  • the amount of issues and prs
  • and the contributors
    The rest seem like surplus content which don't add much IMO

- flat style for all badges
- fix some target urls (CoC, contribs)
- organize url parameters
- capitalize labels
- move contrib/sponsors nest to forks/stars...
- group by paragraph instead of br
@davorpa
Copy link
Member Author

davorpa commented Feb 7, 2022

How looks now?

Better group using paragraphs or by brs like before? Looks a bit gapped

Click to see details about screenshot

Screenshot_20220207-070734
Screenshot_20220207-070753

@eshellman
Copy link
Collaborator

Takes up too much space. One row max. We can fit 3 badges. or send to the bottom of the page.

a PR submit into @badges/shields project is pending to be rendered
@davorpa
Copy link
Member Author

davorpa commented Feb 8, 2022

looks very cluttered. mostly redundant, but I wouldn't object to surfacing the sponsors.

After c600455 commit, it appears a bit less cluttered. Somebody are agree?

Takes up too much space. One row max. We can fit 3 badges. or send to the bottom of the page.

Issues and PR badges could be moved to Contributing section, I thought. But I'm in pro of having all badges glued.

From the point of view of UX, remember that the intention of counter badges is also have a link to, at a glance, easily navigate to that section. Try links and let me know some options more

@eshellman
Copy link
Collaborator

Would welcome comments from the community

@davorpa davorpa added the help wanted Needs help solving a blocked / stucked item label Feb 8, 2022
@CleanMachine1
Copy link
Member

Would welcome comments from the community

My personal opinion on these badges is there current amount seem unprofessional and cluttering, like they are there to purely fill more space.

Maybe some of these badges could be moved such as the help wanted ones to the CONTRIBUTING.md file, it seems more fitting.

I'd also opt to remove the good first issue, it has been used less than 20 times in this projects entire existence from what I can tell so its pretty redundant.

Other than them small issues, LGTM

@LuigiImVector
Copy link
Member

After c600455 commit, it appears a bit less cluttered. Somebody are agree?

seem more orderly even if they are still too many

@davorpa
Copy link
Member Author

davorpa commented Feb 10, 2022

Maybe some of these badges could be moved such as the help wanted ones to the CONTRIBUTING.md file, it seems more fitting.

I agree too.

My feelings: The inconvenient maybe the amout of files to apply to, one of the reason to agree form, temp and space where place it and then avoid alter them again

I'd also opt to remove the good first issue, it has been used less than 20 times in this projects entire existence from what I can tell so its pretty redundant.

Well, issues and PRs counters are informative too. 2x3 grid. "Good first issue" aren't used too much, I thought, because there aren't enough issues yet and this project isn't "really" a coding project, reducing a bit more its amount. But can be used to mark as easy thing to resolve. Eg: see hacktoberfest backlog #5762 pending tasks

README.md Outdated Show resolved Hide resolved
@davorpa davorpa requested a review from CleanMachine1 March 10, 2022 08:44
@CleanMachine1
Copy link
Member

I still have to say, there is an excessive amount of badges, so until we find a solution, I can't agree with the addition

@davorpa
Copy link
Member Author

davorpa commented Mar 11, 2022

@EbookFoundation/reviewers and something like this. It seems less dense, I thought. Each badge in their respective section

Click to see details about screenshot

image

@davorpa davorpa added the conflicts Conflict(s) need to be resolved label Mar 11, 2022
@eshellman
Copy link
Collaborator

MUCH better! Remove or move the "Website up" and the "Contributor covenant" badges, and I think we're set.

@davorpa davorpa removed the conflicts Conflict(s) need to be resolved label Mar 11, 2022
davorpa added 2 commits March 11, 2022 16:06
- MD041/first-line-heading/first-line-h1: First line in a file should be a top-level heading
- MD009/no-trailing-spaces: Trailing spaces [Expected: 0 or 4; Actual: 2]
@davorpa davorpa requested a review from eshellman March 11, 2022 15:47
@davorpa
Copy link
Member Author

davorpa commented Mar 11, 2022

MUCH better! Remove or move the "Website up" and the "Contributor covenant" badges, and I think we're set.

@eshellman check it now again: https://davorpa.github.io/free-programming-books

@davorpa davorpa force-pushed the docs/repo-statistics-badges branch from 535a5e6 to 2e593a2 Compare March 11, 2022 16:43
@LuigiImVector
Copy link
Member

I still have to say, there is an excessive amount of badges, so until we find a solution, I can't agree with the addition

I also think that there are too many badges

@davorpa davorpa force-pushed the docs/repo-statistics-badges branch from 8ec0765 to 898f927 Compare March 13, 2022 08:52
README.md Outdated Show resolved Hide resolved
@davorpa davorpa requested a review from eshellman March 14, 2022 15:27
@eshellman eshellman merged commit 3fdb16f into EbookFoundation:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 discussion This Repo is guided by its community! Let's talk! 👀 Needs Review Is this really a good resource? Reviews requested. help wanted Needs help solving a blocked / stucked item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants