Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maniacs Feature: Add separate Width/Height parameters for scaling pictures #473

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ToolMan2k
Copy link
Contributor

Adds the following lines inside fields_easyrpg.csv:

  • current_scale_width
  • current_scale_height
  • finished_scale_width
  • finished_scale_height

This is in preparation for adding Width/Height support into EasyRPG.

@ToolMan2k ToolMan2k changed the title Maniac Patch: Separate Width/Height data for scaling pictures Maniac Patch: Add separate Width/Height parameters for scaling pictures Dec 28, 2023
@ToolMan2k ToolMan2k changed the title Maniac Patch: Add separate Width/Height parameters for scaling pictures Maniacs Feature: Add separate Width/Height parameters for scaling pictures Dec 28, 2023
@Ghabry
Copy link
Member

Ghabry commented Dec 28, 2023

Hi and thanks for the contribution.

I'm currently on vacation. Will take a look at it in January.

@ToolMan2k
Copy link
Contributor Author

I've changed the pointers so that width uses the same as "magnify", and height uses 0A and 24 for current and finish respectively.

Updated width and height chunk pointers

- current_scale_height set to 0A
- finish_scale_height set to 24
@Ghabry Ghabry added this to the 0.8.1 milestone Mar 11, 2024
@Ghabry Ghabry added the Chunks label Mar 11, 2024
@Ghabry
Copy link
Member

Ghabry commented Mar 11, 2024

jenkins: test this please <3

@Ghabry Ghabry requested a review from fdelapena March 25, 2024 22:51
@Ghabry Ghabry merged commit 41f537e into EasyRPG:master Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants