Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #379
I've added support for
DBBitArray
as a replacement forvector<bool>
. This data structure again uses the same memory allocation strategy asDBString
andDBArray
.The overall savings here are pretty modest Lets look more closely at hh3's database with certain structs compiled out. This game has 850 skills and 2280 items.
Memory usage:
So overall, we see a good % reduction in the size of items and skills. Unfortunately these don't make up a huge portion of the database, so the total win is pretty small.
Still overall, it's a net gain and could help a bit on memory constrained systems.