Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freeimage and workflow #178

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

carstene1ns
Copy link
Member

The vcpkg library uses additional patches and has more dependencies. We need to check how much weight this adds and could run our own later.

@carstene1ns carstene1ns force-pushed the add-freeimage branch 7 times, most recently from 32240ef to 506131d Compare June 11, 2024 21:26
@carstene1ns carstene1ns marked this pull request as ready for review June 11, 2024 21:34
@Ghabry
Copy link
Member

Ghabry commented Aug 25, 2024

Maybe move this in a build_tools.cmd so this isn't built by default? Though building freeimage and (soon) wxwidgets aren't that big.


There are alot of dependencies but they are all small and compile fast so works for me.

I only suggest setting webp to core to get rid of alot of dependencies:

libwebp[core] freeimage[core]

jasper could be also set to core to avoid pulling in opengl but wxwidgets has opengl as a required dep so it doesn't matter...


With WX:

libwebp[core] freeimage[core] wxwidgets[core]

windows/build.cmd Outdated Show resolved Hide resolved
@Ghabry Ghabry merged commit 990e522 into EasyRPG:master Sep 22, 2024
11 checks passed
@Ghabry
Copy link
Member

Ghabry commented Sep 22, 2024

(Please do not rebuild windows. Fmtlib has a bug and breaks the build)

@carstene1ns carstene1ns deleted the add-freeimage branch September 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants