Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style make targets to pass during release #331

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Aug 9, 2024

Description

The release failed because we weren't installing our styleguide so the process could check it. This fixes the makefile targets to allow us to use a styleguide specific one for releasing and clarifies and updates the dependencies for this on normal installs.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team August 9, 2024 21:59
@Justintime50 Justintime50 merged commit c1839b9 into master Aug 9, 2024
18 checks passed
@Justintime50 Justintime50 deleted the fix_release_styles branch August 9, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants