Only return the new implemented requirement #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelmay
force-pushed
the
suggestion/update-ssp-impl-req
branch
from
5e1bda1
to
f812640
Compare
Per the specification, we must return the _new_ implemented requirement object; not the entire SSP. We can add somewhat more generic versions of the existing `makeXxxResponse` methods for this use case (and we can leave the old implementations as more convenient wrappers for the root object types).
laurelmay
force-pushed
the
suggestion/update-ssp-impl-req
branch
from
f812640
to
35ecf88
Compare
rgauss
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the specification, we must return the new implemented requirement
object; not the entire SSP. We can add somewhat more generic versions of
the existing
makeXxxResponsemethods for this use case (and we canleave the old implementations as more convenient wrappers for the root
object types).