Fix bug with tabs being invisible when an association or similar has … #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property with same label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…property with same label.
Situation:
Class A has property B
Class C has also property B
Class A has also reference to Class C
Class A Crud Controller displays Association to C, and also another Association to B.
Now, when this happens the Crud Edit Interface will no longer display the Association of a tab. This is because of the tabId generation that takes into account only the label, which means that for many more situations (not just the one above), Tabs cannot be utilized correctly.
This bugfix causes this issue by adding a uniqid to an invisible-to-the-user ID, that must be unique anyway.