Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tabs conflicts in CollectionField when using "useEntryCrudForm" #6464

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Fix tabs conflicts in CollectionField when using "useEntryCrudForm" #6464

wants to merge 1 commit into from

Conversation

ggabrovski
Copy link
Contributor

Fix tabs conflicts in CollectionField when using "useEntryCrudForm" with tabs.
See #5690

@javiereguiluz
Copy link
Collaborator

Let's see if we can fix this without using an Ulid in the tab ID. This ID is visible in the URL and the Ulid would make it very long and a bit ugly. Let's try to find an alternative solution. Thanks.

@Seb33300
Copy link
Contributor

Also, FieldDto already has a $uniqueId property with an Ulid. But that property is internal.
If we finally decide to use an Ulid, we may decide to change this so we can reuse that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggabrovski @javiereguiluz @Seb33300