New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Interface for `AdminContextProvider` and replaced types in injected classes #6088

Open

bytes-commerce wants to merge 5 commits into EasyCorp:4.x from bytes-commerce:admin-context-provider-interface

Contributor

bytes-commerce commented Jan 4, 2024

This adds another Interface for a final class without existing Interface.

Works regardless of service.php declarations -> the instanceof should always run trough fine. Tests may have to be adapted accordingly.


          Add Interface and replaced types in injected classes.

15a3e19

bytes-commerce changed the title ~~Add Interface and replaced types in injected classes.~~ Add Interface for AdminContext and replaced types in injected classes.

OskarStark changed the title ~~Add Interface for AdminContext and replaced types in injected classes.~~ Add Interface for AdminContext and replaced types in injected classes.´

OskarStark changed the title ~~Add Interface for AdminContext and replaced types in injected classes.´~~ Add Interface for AdminContext and replaced types in injected classes

OskarStark reviewed

View reviewed changes

src/Inspector/DataCollector.php Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

src/Form/Extension/EaCrudFormTypeExtension.php Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

src/Field/Configurator/CommonPostConfigurator.php Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

src/Factory/PaginatorFactory.php Outdated Show resolved Hide resolved

OskarStark reviewed

View reviewed changes

src/Provider/AdminContextProviderInterface.php Outdated Show resolved Hide resolved

bytes-commerce added 3 commits

January 4, 2024 14:59


          removed property declaration and implemented PHP8 shorthand construct…

6ecf908

… initialization of properties.

Signed-off-by: Maximilian Graf Schimmelmann <[email protected]>


          Added whitespaces, fixed Phpcs feedback, removed unused use imports.


          Removed phpdoc from interface

0bfcda2

OskarStark changed the title ~~Add Interface for AdminContext and replaced types in injected classes~~ Add Interface for AdminContextProvider and replaced types in injected classes


          Add shorthand initialization for properties in constructor for argume…

dd090bf

…nt resolver classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet