Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[findEntityFqcnByCrud] - Allows you to find the Fqcn of an entity fro… #6030

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

qhayat
Copy link

@qhayat qhayat commented Nov 20, 2023

When using easy admin in a bundle, it does not map the crud in crudFqcnToEntityFqcnMap.

Since the Crud holds the Fqcn of the linked entity. I propose:

  • Rename the method findEntityFqcnByCrudFqcn to findEntityFqcnByCrud wich take an instance of CrudControllerInterface.
  • Then if the method does not find the mapping, it will use the getEntityFqcn method of the crud passed as a parameter.

ps: Namely the findEntityFqcnByCrudFqcn method is only called once in AdminContextFactory

…m the crud, either based on the 'findEntityFqcnByCrud' or on the 'findEntityFqcnByCrud' method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant