Abstracted more repeating code, added abstract for fields, made creat… #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of new fields more streamlined and adapted signature to match possible inputs more strictly.
This comment was marked as outdated.
This comment was marked as outdated.
OskarStark
reviewed
Nov 8, 2023
|
|
||
| public function getAsDto(): FieldDto; | ||
|
|
There was a problem hiding this comment.
adding methods to an interface is a BC break, you should use @method annotations instead
There was a problem hiding this comment.
You are right, I am afraid, but using @method will not improve the situation; the opposite is the case, as IDEs would indicate methods that are not even there maybe, creating a booby trap for developers. I am considering a individual Interface for the existing fields, which then would be BC compatible by just extending the given Interface. 🤔 Something like FieldTraitAwareInterface or similar. Thanks for the heads up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion of new fields more streamlined and adapted signature to match possible inputs more strictly.
This PR streamlines how Fields are generated; instead of lots of code duplication (that increases the costs for maintenance), we can deduct it to an Abstract.
In an attempt to further reduce abstracts, this change can be later on used to even further simplify static calls by having the full API of the fields at hand.