Add updated source files to Updates folder #91
Conversation
src/Updates/EarthSciData.jl
Outdated
There was a problem hiding this comment.
How is this file different from src/EarthSciData.jl? Can we make changes to src/EarthSciData.jl instead of creating a new file here?
There was a problem hiding this comment.
Yes, sure. Just had put them temporarily to check with you first. I made changes to the original files and created a new pull request.
src/Updates/load.jl
Outdated
There was a problem hiding this comment.
How is this file different from src/load.jl? Can we make changes to src/load.jl instead of creating a new file here?
There was a problem hiding this comment.
Same as above. I initially created these files temporarily for review purposes. I've now made the necessary changes to the original files and opened a new pull request.
src/Updates/utils.jl
Outdated
There was a problem hiding this comment.
How is this file different from src/utils.jl? Can we make changes to src/utils.jl instead of creating a new file here?
There was a problem hiding this comment.
Same as above. I initially created these files temporarily for review purposes. I've now made the necessary changes to the original files and opened a new pull request.
src/Updates/wrf.jl
Outdated
There was a problem hiding this comment.
Would it work to put this file directly in the src directory rather than creating a new Updates directory to put in?
There was a problem hiding this comment.
Yes, I’ve moved it directly to src in the new pull request.
There was a problem hiding this comment.
Also add a line in test/runtests.jl to run this file as part of the test suite.
EarthSciData.jl/test/runtests.jl
Line 6 in dfb461e
There was a problem hiding this comment.
I’ve added a line to test/runtests.jl to include wrf_test.jl in the test suite.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
===========================================
- Coverage 95.00% 42.34% -52.66%
===========================================
Files 9 11 +2
Lines 500 1195 +695
===========================================
+ Hits 475 506 +31
- Misses 25 689 +664 ☔ View full report in Codecov by Sentry. |
Updated files: 1. EarthSciData.jl 2. load.jl 3. utils.jl New files: 1. wrf.jl 2. wrf_test.jl
Added wrf.jl and wrf_test.jl. Minor updates to: EarthSciData.jl, utils.jl, and runtests.jl.
Added wrf.jl that handles WRF data processing.
Minor modifications were made to EarthSciData.jl, load.jl, and utils.jl
to integrate with wrf.jl