Skip to content

Commit

Permalink
[rb] Add base64 gem as a runtime dependency
Browse files Browse the repository at this point in the history
Ruby 3.3 shows a warning if requiring base64 without specifying it in the gemspec
Ruby 3.4 will throw a warning.
See https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.3.0.md#stdlib-updates

Closes SeleniumHQ#13447
  • Loading branch information
Earlopain committed Jan 18, 2024
1 parent 328e241 commit 3f6eb54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions rb/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PATH
selenium-devtools (0.120.0)
selenium-webdriver (~> 4.2)
selenium-webdriver (4.17.0.nightly)
base64
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
Expand Down
1 change: 1 addition & 0 deletions rb/selenium-webdriver.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Gem::Specification.new do |s|
s.bindir = 'bin'
s.require_paths = ['lib']

s.add_runtime_dependency 'base64'
s.add_runtime_dependency 'rexml', ['~> 3.2', '>= 3.2.5']
s.add_runtime_dependency 'rubyzip', ['>= 1.2.2', '< 3.0']
s.add_runtime_dependency 'websocket', ['~> 1.0']
Expand Down

0 comments on commit 3f6eb54

Please sign in to comment.