Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hardcoded speed limit for turns and swings #39

Closed
ssejrog opened this issue Jan 9, 2022 · 1 comment
Closed

fix hardcoded speed limit for turns and swings #39

ssejrog opened this issue Jan 9, 2022 · 1 comment
Assignees
@ssejrog
Labels
bug Something isn't working

Comments

@ssejrog
Copy link
Member

ssejrog commented Jan 9, 2022

the speed of turning and swinigng when i is enabled is clipped to a hardcoded number for some reason. this is stupid. this should have never been like this. add function to change this.
@ssejrog ssejrog added the bug Something isn't working label Jan 9, 2022
@ssejrog ssejrog self-assigned this Jan 9, 2022
@ssejrog ssejrog changed the title Bug Repot Template fix hardcoded speed limit for turns and swings Jan 9, 2022
ssejrog added a commit that referenced this issue Jan 9, 2022
@ssejrog
Fixed swing/turn min (#39)
2984d68
@ssejrog
Copy link
Member Author

ssejrog commented Jan 9, 2022

Added get_swing_min(), set_swing_min(), get_turn_min(), set_turn_min().

These set/get the minimum power of the drive when kI is enabled and the target is greater then startI.

Also fixed error in the swing_pid_task where turnPID was used instead of swingPID.

@ssejrog ssejrog closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssejrog ssejrog

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssejrog