Lydia/bugs in InternalFunctionCall4 (formerly named InternalFunctionCall2) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interact with a secret only within the internal function call are marked as not interacting with the secret and so not input to the proof in the orchestration
…at use the same secret state variable
…t state variable in orchestration and circuits
…ifying same secret state - specifically in the statements array where statements from internal functions are combined
…rs were being called
…e same secret state
…circuit but only used in an internal function call - this means that the same variable is declared twice
…ssed variables in orchestration
…hen circuits are not imported
…ecause the fuction only interacts with the secret in the internal function calls
…ith secret not being counted as interacting with secret
…rt statement list is not updated
SwatiEY
approved these changes
Jun 10, 2024
|
🎉 This PR is included in version 1.5.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are bugs due to the fact that non-secret parameters are input to internal function calls but interact with global secrets within the function call. For example the non-secret parameters are not input to the proof or nullified during orchestration.