shared secret #237
Merged
shared secret #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kKahina
reviewed
Apr 12, 2024
kKahina
reviewed
Apr 12, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| // Q: how are we merging mapping key and ownerPK in edge case? | |||
| // Q: should we reduce constraints a mapping's commitment's preimage by not having the extra inner hash? Not at the moment, because it adds complexity to transpilation. | |||
| import fs from 'fs'; | |||
| import fs, { stat } from 'fs'; | |||
There was a problem hiding this comment.
{stat} where stat is used ?
| // For a state variable, we'll have passed in `${x}_oldCommitment_value` as a parameter. But our AST nodes will be using `${x}`. This line resolves the two. | ||
| if (reinitialisable) | ||
| return [ `${typeName ? typeName : 'field'} ${x} = 0`]; |
There was a problem hiding this comment.
${x}=0, because commitment are not nullified ?
kKahina
approved these changes
Apr 12, 2024
lydiagarms
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Is the containsAccessedOnlyStates relevant to this pull request?
There was a problem hiding this comment.
Is line 63 one of the nullifier changes?
There was a problem hiding this comment.
Are the changes on line 110 and lines 139-141 related to this pull request or are they from when the nullifier checking was being changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a decorator
sharedSecret, and the corresponding api to get the shared keys. If a state is marked as sharedSecret implies that can be state variable is shared between two parties, thus can be nullified by both of them.