🔥 Remove support for OCPP 1.6J #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankari
force-pushed
the
fix_demo_issues_remove_16j_support
branch
from
6f0db64
to
084bc3d
Compare
It is the manager config, and it will ensure that we don't clutter up the main directory Signed-off-by: Shankari <[email protected]>
Also plan for removing the OCPP 1.6J support since that uses StEVe which has a weird build mechanism, is flaky and is not maintained. We want to enable CI for this repo soon and having a flaky build would be very annoying. Signed-off-by: Shankari <[email protected]>
- OCPP 1.6J is no longer part of the NEVI requirements in the US
- OCPP has switched to developing 2.1, so 1.6J is two releases old
- The 1.6J demo used StEVe as the CSMS, which was known to be flaky
- It is not clear when anybody last ran the 11.6J demo, and whether it is
still working or has bitrotted
- We now support two 201 CSMSes, so we are not picking a single integration
point, and can still test interoperability
- We want to add CI for this repo so that we can see if anything is
broken/bitrotted. If it isn't tested, it isn't working. We don't want a flaky
demo in there confusing everything.
Signed-off-by: Shankari <[email protected]>
shankari
force-pushed
the
fix_demo_issues_remove_16j_support
branch
from
084bc3d
to
77bf991
Compare
Testing logs (screenshot below 👇 )
|
shankari
force-pushed
the
fix_demo_issues_remove_16j_support
branch
from
684194a
to
4ec290f
Compare
Since it has been removed from maeve thoughtworks/maeve-csms@a1018d6 This will avoid the following error ``` Patching the CSMS to disable load balancer patching file docker-compose.yml Already applied patch found... 4 out of 4 hunks ignored--saving rejects to docker-compose.yml.rej ``` Signed-off-by: Shankari <[email protected]>
shankari
force-pushed
the
fix_demo_issues_remove_16j_support
branch
from
4ec290f
to
c84058d
Compare
shankari
added a commit
to US-JOET/everest-demo
that referenced
this pull request
Nov 13, 2024
- `config-docker.json`: is no longer needed since we don't support 1.6j (EVerest#80) - `config.json` is no longer needed, since it is removed and replaced by the `component_config` directory (EVerest/libocpp#740) - `device_model_storage_maeve_sp1.db` is now created by the manager at startup based on the `component_config` directory This should now work for the basic (non-ISO/non-OCPP use cases) Signed-off-by: Shankari <[email protected]>
shankari
added a commit
to US-JOET/everest-demo
that referenced
this pull request
Nov 13, 2024
- `config-docker.json`: is no longer needed since we don't support 1.6j (EVerest#80) - `config.json` is no longer needed, since it is removed and replaced by the `component_config` directory (EVerest/libocpp#740) - `device_model_storage_maeve_sp1.db` is now created by the manager at startup based on the `component_config` directory This should now work for the basic (non-ISO/non-OCPP use cases) Signed-off-by: Shankari <[email protected]>
shankari
added a commit
to US-JOET/everest-demo
that referenced
this pull request
Nov 13, 2024
- `config-docker.json`: is no longer needed since we don't support 1.6j (EVerest#80) - `config.json` is no longer needed, since it is removed and replaced by the `component_config` directory (EVerest/libocpp#740) - `device_model_storage_maeve_sp1.db` is now created by the manager at startup based on the `component_config` directory This should now work for the basic (non-ISO/non-OCPP use cases) Signed-off-by: Shankari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- It is not clear when anybody last ran the 11.6J demo, and whether it is
still working or has bitrotted
and couple of renames/cleanups to prep for a future ac + dc demo.