Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from previous PR on Running automated tests via CICD #67

Merged
merged 4 commits into from
Sep 18, 2024

Commits on Jul 16, 2024

  1. Bringing in changes from previous PR on Running automated tests via CICD

    The previous PR commit history got messed up due to rebasing to handle the commits that had missing signoffs.
    Created a new PR to bring over the final changes from there.
    
    PR link: EVerest#62
    
    Signed-off-by: Mahadik, Mukul Chandrakant <[email protected]>
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fe1b1fa View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Using artifacts to make mqtt server image accessible in manager matri…

    …x job
    
    Found out an issue with the latest tagged image not being fetched in the docker compose command.
    The reason was that the matrix job only loaded its respective image from the cache.
    But the docker compose command for running automated tests uses both manager and mqtt server images.
    
    To solve this, initially I used docker build push action to reload the mqtt image in the matrix job for manager.
    But then finally went with the approach of using artifacts to share the mqtt image between jobs - uploaded in mqtt matrix job, downloaded in manager matrix job.
    
    Signed-off-by: Mahadik, Mukul Chandrakant <[email protected]>
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    007ad27 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Added suggested fixes after code review on 08/06/24

    Signed-off-by: Mahadik, Mukul Chandrakant <[email protected]>
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    43eb83a View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Update Dockerfile

    Added the hardcoded build-kit alpine image with the EVEREST_VERSION = 2024.3.0 and matching SHA256 digest to the previous latest tag version which has now been moved to untagged (7494bd6624aee3f882b4f1edbc589879e1d6d0ccc2c58f3f5c87ac1838ccd1de)
    
    Found this image by going through the logs in the last successful run (in my forked repo) and looking at the FROM layer in the Docker build step.
    fa60246
    
    Image link:
    https://github.com/everest/everest-ci/pkgs/container/build-kit-alpine/161694439
    
    ---
    
    Expected: Should pass since it matches configurations of last successful run with matching EVEREST_VERSION and SHA256 digest for build-kit alpine base image.
    
    ----
    
    Will add more details in PR comments.
    
    ----
    
    Signed-off-by: Mahadik, Mukul Chandrakant <[email protected]>
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e80a625 View commit details
    Browse the repository at this point in the history