Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the power drawn in the ISO 15118-2 DC demo to 160 kW #4

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

drmrd
Copy link
Contributor

@drmrd drmrd commented Nov 17, 2023

The current ISO 15118-2 DC demo includes a charger configured to provide power to a simulated EV at a rate of roughly 6 kW. These changes modify the charger configuration to up this rate to 160 kW, which is more representative of a typical DC fast charging session.

@shankari
Copy link
Collaborator

shankari commented Nov 19, 2023

@drmrd does this actually work? I believe it required a change to the image for it to work, and I don't see any image changes here...

@drmrd
Copy link
Contributor Author

drmrd commented Nov 20, 2023

@shankari: It does not without additional work. The user-config directory needs to be copied into manager during the build process.

@couryrr-afs: Can you push the manager update you refer to here that does this?

@couryrr-afs
Copy link
Contributor

@drmrd should I be pushing a docker container? I can do so but it may become out of date if not automated with the CI/CD pipeline. I was having permission issues when doing attempting this previously.

@shankari
Copy link
Collaborator

@couryrr-afs as you can see from the current workflow, you should be able to rebuild containers by submitting a PR to a branch that starts with build_pkg. The CI/CD pipeline will build it in that case.
https://github.com/US-JOET/everest-demo/blob/main/.github/workflows/cicd.yaml

I think we should revisit even the current cicd pipeline to tag the images by date/time instead of branch, so that we can keep a single build_pkg branch sitting around to rebuild containers. And over the long-term, the build should really happen in the individual repos.
https://github.com/US-JOET/everest-demo-private/issues/16#issuecomment-1781556836

@couryrr-afs
Copy link
Contributor

@drmrd and @shankari it looks like this will push an image to the US-JOET. If we are okay with that for the time being then after this PR action runs the new image should have what is needed in the manager. The issue I was referring to was permission based for pushing images.

As for the image versioning there are various build and tagging strategy that we can use. As the the CI/CD pipeline matures we can implement those.

@shankari
Copy link
Collaborator

it looks like this will push an image to the US-JOET. If we are okay with that

Yes, as outlined in the issue https://github.com/US-JOET/everest-demo-private/issues/16, this is the current process. We do not want the perfect to be the enemy of the good.

after this PR action runs the new image should have what is needed in the manager.

To get the PR action to run, you will need to submit a PR to us-joet. Since this is a common theme across the PRs, I have created a new branch for this - build_pkg_task_1_features

The issue I was referring to was permission based for pushing images.

images created by github actions automatically have permissions for pushing images

As for the image versioning there are various build and tagging strategy that we can use. As the the CI/CD pipeline matures we can implement those.

Yes, there are various strategies. Can you open an issue and make a proposal on which one to use? The current flow works for the interim, but is clearly very clunky

@drmrd drmrd changed the title Up the amount of power drawn in the ISO 15118-2 DC demo to 160 kW Increase the power drawn in the ISO 15118-2 DC demo to 160 kW Dec 6, 2023
@drmrd
Copy link
Contributor Author

drmrd commented Dec 6, 2023

Waiting on an update with the correct manager Dockerfile and to set a correct image tag.

@shankari: This should now be ready to be merged after #3.
ETA: and #11.

@drmrd
Copy link
Contributor Author

drmrd commented Dec 6, 2023

@shankari: This PR should now be ready to merge.

@shankari shankari merged commit e055182 into EVerest:main Dec 6, 2023
4 checks passed
@drmrd drmrd deleted the fix-kilowatts-in-dc-demo branch December 6, 2023 19:20
louisg1337 pushed a commit to louisg1337/everest-demo that referenced this pull request Jun 18, 2024
Fixes to get the simulation to work with the current HEAD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants