-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EvseSecurity module documentation #591
Conversation
Signed-off-by: pietfried <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
dc9c372
to
1813d3f
Compare
Signed-off-by: pietfried <[email protected]>
1813d3f
to
123df7e
Compare
Signed-off-by: pietfried <[email protected]>
Should we delete the docs directory? There is another index.rst in there that seems not to be needed. I guess the current docs concept is: Having either the docs directory OR the docs.rst, right? |
Signed-off-by: pietfried <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I welcome these docs!
I miss an instruction on the expected bundles and how to construct them. Trying to use certificates from CharIN (testival Jan 2024, created by Keysight), I reverse-engineered what is created by cmake
and make install
in everest-core in order to get libevse-security to accept them.
modules/EvseSecurity/doc.rst
Outdated
Configuration for ISO15118 | ||
-------------------------- | ||
|
||
For ISO15118 communication, the charging station provides a server endpoint to which the electric vehicle connects. The communication may be secured using TLS. TLS is mandatory for Plug&Charge. If TLS is used, the correct configuration of the ``secc_leaf_cert_directory`` and ``secc_leaf_key_directory`` is required. These directories are used to locate the server certificate and key for the ISO15118 TLS server provided by the charging station. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact: In ISO 15118-20, PnC expands to "Park'n'Charge" 😉
Signed-off-by: Krealyt <[email protected]>
…t/everest-core into docs/evse-security-module
Signed-off-by: pietfried <[email protected]>
The docs of this module attempt to be a generic description of what the module does and mainly how you should configure it including some advice for OCPP and ISO15118. Further, there is Plug&Charge tutorial coming up soon. We're thinking about adding a broader explaination of how all the security relevant processes and access is related across multiple EVerest modules (OCPP, EvseV2G, EvseManager, Auth, EvseSecurity) for ISO15118, Plug&Charge and OCPP. |
* EvseSecurity module documentation --------- Signed-off-by: pietfried <[email protected]> Signed-off-by: Krealyt <[email protected]> Co-authored-by: Krealyt <[email protected]>
Describe your changes
This PR adds custom module documentation for the EvseSecurity module
Issue ticket number and link
Checklist before requesting a review