Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for groupIdToken and MasterPassGroupId #577

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Support for groupIdToken and MasterPassGroupId #577

merged 5 commits into from
Mar 8, 2024

Conversation

Pietfried
Copy link
Contributor

Added support for groupIdToken and MasterPassGroupId in OCPP, OCPP201 and Auth module:

  • Added IdToken type to authorization.yaml (contains value: string and type: IdTokenType)
  • Changed type of ProvidedIdToken.id_token to this new type: /authorization#/IdToken
  • Added parent_id_token (/authorization#/IdToken) to ProdivdedIdToken and ValidationResult
  • refactored modules that were affected by the changes of types and interfaces

@Pietfried
* refactored authorization type to add group id token to support it i…
48c13dd 
…n OCPP201

* Added support for groupIdToken in OCPP, OCPP201 and Auth module

Signed-off-by: pietfried <[email protected]>
@hikinggrass
Codacy fixes
1a4cea2 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
SebaLukas
SebaLukas approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Pietfried Pietfried merged commit 55416be into main Mar 8, 2024
4 of 5 checks passed
@Pietfried Pietfried deleted the feature/group-id-token branch March 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaLukas SebaLukas SebaLukas approved these changes

@hikinggrass hikinggrass hikinggrass approved these changes

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pietfried @hikinggrass @SebaLukas