Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure OCPP and OCPP201 modules: Moved conversions #561

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

Pietfried
Copy link
Contributor

  • Added conversions headers and implementations for OCPP and OCPP201 modules
  • Refactored OCPP and OCPP201 modules to use conversion functions instead of string conversions

Copy link
Contributor

@hikinggrass hikinggrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just this one strange conversion from types::evse_manager::StopTransactionReason to ocpp::v201::ChargingStateEnum. that's either accidental or needs a clearly state reason in a comment

…modules

* Refactored OCPP and OCPP201 modules to use conversion functions instead of string conversions

Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried merged commit 2a4a8fd into main Mar 5, 2024
5 checks passed
@Pietfried Pietfried deleted the refactor/ocpp-conversions branch March 5, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants