Use artifacts instead of GHCR for build-kit-<reponame> #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
3 tasks
a-w50
reviewed
Oct 22, 2024
| name: Build and Push Build Kit | ||
| uses: everest/everest-ci/.github/workflows/[email protected] | ||
|
|
||
| build-build-kit: |
There was a problem hiding this comment.
build-build-kit sounds a bit strange
There was a problem hiding this comment.
Naming is hard :) I am open for suggestions
| run: | | ||
| docker pull --quiet ${{ env.BUILD_KIT_IMAGE }} | ||
| docker load -i build-kit.tar | ||
| docker image tag ${{ env.BUILD_KIT_IMAGE }} build-kit |
There was a problem hiding this comment.
is this tag still necessary if the image has been tagged already before?
There was a problem hiding this comment.
It is not necessary but with this it is enough to just "hard code" build-kit as image name in the following.
If it wouldn't be tagged you would need to stick to ${{ env.BUILD_KIT_IMAGE }} everywhere which decreases readability
* Use tags for build-kit-<reponame> * Don't support multi platform build Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
3 tasks
Signed-off-by: Andreas Heinrich <[email protected]>
andistorm
force-pushed
the
bugfix/build-kit-in-forks
branch
from
b19fecf
to
9d528ed
Compare
hikinggrass
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the forklow in a PR coming from a fork it is not possible to push to the Github Container Registry since secrets are not available in a "fork run".
build-kit.tarand upload as artifactbuild-kit.tar