Add support for crypto currencies #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lockefox
commented
Sep 10, 2017
README.rst
Outdated
|
|
||
| - Ticker Info: get info about coin<->currency conversion metadata | ||
| - Price Quote: get latest OHLC data for given coin | ||
| - Price History: get history of coin price |
There was a problem hiding this comment.
Price history not supported, don't put it in the README
| """ | ||
| symbols_df = pd.DataFrame(get_supported_symbols_hitbtc()) | ||
|
|
||
| unique_list = list(symbols_df[key_name].unique()) |
There was a problem hiding this comment.
Make sure there's a test for unsupported key_name
| LOGGER = config.LOGGER | ||
| HERE = path.abspath(path.dirname(__file__)) | ||
|
|
||
| __all__ = ('get_orderbook_hitbtc', 'get_quote_hitbtc') |
There was a problem hiding this comment.
add 2 newlines before class
prosper/datareader/coins/prices.py
Outdated
| req.raise_for_status() | ||
|
|
||
| data = req.json() | ||
| if not symbol: |
There was a problem hiding this comment.
add comment: why if not symbol
| data = req.json() | ||
|
|
||
| return data #return both bids/asks for other steps to clean up later | ||
|
|
There was a problem hiding this comment.
add a divider between helpers/real funcs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using hitBTC add support for looking at crypto currencies
.coinssubgrouptickers: coin + currency FOREX style lookup keys3.7-devfrom travis plan. Pandas vs 3.7 is causing more noise than signal