Review of V3.0.0 changes #1842

hjhsalo · 2021-03-15T12:35:57Z

Let's review what changes v3.0.0 introduces.

This change is

hjhsalo

Review still WIP, but need to close it in order for others to see the comments.
Let's see if review can be closed and reopened.

hjhsalo · 2021-03-15T12:50:49Z

b2share/config.py

@@ -31,7 +21,11 @@
 from b2share.modules.access.permissions import admin_only, authenticated_only
 from celery.schedules import crontab
 from flask import request
+
+from invenio_app.config import APP_DEFAULT_SECURE_HEADERS


Reference? Link to documentation?

hjhsalo · 2021-03-15T12:51:12Z

b2share/config.py

@@ -31,7 +21,11 @@
 from b2share.modules.access.permissions import admin_only, authenticated_only
 from celery.schedules import crontab
 from flask import request
+
+from invenio_app.config import APP_DEFAULT_SECURE_HEADERS
+# from invenio_previewer.config import PREVIEWER_PREFERENCE as BASE_PREFERENCE


Why this is commented out?
Reference?

hjhsalo · 2021-03-15T12:52:41Z

b2share/config.py

+# Rate limiting
+# =============
+#: Storage for ratelimiter.
+RATELIMIT_STORAGE_URL = os.environ.get("INVENIO_RATELIMIT_STORAGE_URL", 'redis://localhost:6379/3')


Reference? Link to docs?

hjhsalo · 2021-03-15T12:53:01Z

b2share/config.py

+def _(x):
+    """Identity function used to trigger string extraction."""
+    return x


What is this?

Might related to Babel (http://babel.pocoo.org)

Seems to be coming from https://github.com/inveniosoftware/cookiecutter-invenio-instance/blob/55645e9b56db0f52ae0235efa68c72bf173c1d40/%7B%7Bcookiecutter.project_shortname%7D%7D/%7B%7Bcookiecutter.package_name%7D%7D/config.py#L16-L18

hjhsalo · 2021-03-15T12:54:06Z

b2share/config.py

+# Base templates
+# ==============
+#: Global base template.
+BASE_TEMPLATE = 'b2share_main/base.html'
+#: Cover page base template (used for e.g. login/sign-up).
+COVER_TEMPLATE = 'invenio_theme/page_cover.html'
+#: Footer base template.
+MAIN_TEMPLATE = 'invenio_theme/footer.html'
+#: Header base template.
+HEADER_TEMPLATE = 'invenio_theme/header.html'
+#: Settings base template.
+SETTINGS_TEMPLATE = 'invenio_theme/page_settings.html'
+
+# Theme configuration
+# ===================
+#: Site name
+THEME_SITENAME = _('B2SHARE')
+#: Use default frontpage.
+THEME_FRONTPAGE = True
+#: Frontpage title.
+THEME_FRONTPAGE_TITLE = _('B2SHARE')
+#: Frontpage template.
+THEME_FRONTPAGE_TEMPLATE = 'b2share_main/page.html'


Which Invenio modules require/provides templates now?
At least invenio-admin provides the admin UI.

HK: Since invenio-cookiecutter includes invenio-theme, codebase based on invenio-cookiecutter requires theme defining.

hjhsalo · 2021-03-15T12:54:35Z

b2share/config.py

+# Assets
+# ======
+#: Static files collection method (defaults to copying files).
+COLLECT_STORAGE = 'flask_collect.storage.file'


Reference? Link to documentation?

hjhsalo · 2021-03-15T12:54:56Z

b2share/config.py

+# Email configuration
+# ===================
+#: Email address for support.
+SUPPORT_EMAIL = "[email protected]"
+#: Disable email sending by default.
+MAIL_SUPPRESS_SEND = True


Link to documentation? Invenio-Mail perhaps?

hjhsalo · 2021-03-15T12:59:44Z

b2share/config.py

+# Accounts
+# ========
+#: Email address used as sender of account registration emails.
+SECURITY_EMAIL_SENDER = SUPPORT_EMAIL
+#: Email subject for account registration emails.
+SECURITY_EMAIL_SUBJECT_REGISTER = _(
+    "Welcome to B2SHARE!")
+#: Redis session storage URL.
+CACHE_REDIS_URL=os.environ.get("INVENIO_CACHE_REDIS_URL", 'redis://localhost:6379/0')
+ACCOUNTS_SESSION_REDIS_URL = os.environ.get("INVENIO_ACCOUNTS_SESSION_REDIS_URL", 'redis://localhost:6379/1')
+#: Enable session/user id request tracing. This feature will add X-Session-ID
+#: and X-User-ID headers to HTTP response. You MUST ensure that NGINX (or other
+#: proxies) removes these headers again before sending the response to the
+#: client. Set to False, in case of doubt.
+ACCOUNTS_USERINFO_HEADERS = True


Is this only Invenio-Accounts or are there configuration variables for inveniosoftware/flask-security in here as well?

BTW, There is for of flask-security, originally named flask-security-too (pallets-eco/flask-security-3.0#822 (comment)), which seems to be named to Flask-Middleware/flask-security: https://github.com/Flask-Middleware/flask-security

IDK, will inveniosoftware move to use Flask-Middleware/flask-security in the future or have they already done it.

INVENIO_ACCOUNTS_SESSION_REDIS_URL : Note that V3 uses invenio-cache: https://github.com/inveniosoftware/invenio-cache

It might be that V2 codebase invenio modules use Redis directly and now they handle their caching needs through invenio-cache.

hjhsalo · 2021-03-15T13:14:42Z

b2share/config.py

+# Database
+# ========
+#: Database URI including user and password
+SQLALCHEMY_DATABASE_URI = os.environ.get("INVENIO_SQLALCHEMY_DATABASE_URI", \
+    'postgresql+psycopg2://b2share:b2share@localhost/b2share')


Documentation can be found from docs of invenio-db, but maybe we should gather Invenio documentation links to our developer documentation for any newcomers & onboarding activities.

hjhsalo · 2021-03-15T13:19:08Z

b2share/config.py

+#: It should be changed before deploying.
+SECRET_KEY = 'CHANGE_ME'
+#: Max upload size for form data via application/mulitpart-formdata.
+MAX_CONTENT_LENGTH = 100 * 1024 * 1024  # 100 MiB


It might be that Invenio has changed the logic behind invenio-files-rest, since this MAX_CONTENT_LENGTH has been defined here.
-> Is FILES_REST_DEFAULT_MAX_FILE_SIZE is not used any more? (

b2share/b2share/config.py

Lines 406 to 409 in d846068

FILES_REST_DEFAULT_MAX_FILE_SIZE = 10 * 1024 * 1024 * 1024 # 10 GB per file

"""Maximum file size for the files in a record"""

FILES_REST_DEFAULT_QUOTA_SIZE = 20 * 1024 * 1024 * 1024 # 20 GB per record

)

HK: Unit tests might benefit from a test that uploads a large test file, maybe generated on-the-fly during tests.

hjhsalo · 2021-03-15T13:22:06Z

b2share/config.py

+#: should be set to the correct host and it is strongly recommended to only
+#: route correct hosts to the application.
+APP_ALLOWED_HOSTS = [ os.environ.get("SERVER_NAME", 'localhost'), os.environ.get("SERVER_INTERNAL_IP", '127.0.0.1') ]
+APP_ALLOWED_HOSTS = None


HK: Setting APP_ALLOWED_HOSTS to None enables requests from anywhere. DO NOT USE THIS IN PRODUCTION. This has been set for development.

Essentially this needs to be set to e.g. domain name of the server where B2SHARE is hosted; (i.e. is being requested from by the client).
See line above for production suitable value.

hjhsalo · 2021-03-15T13:23:25Z

b2share/config.py

+# Previewers
+# ==========
+#: Include IIIF preview for images.
+# PREVIEWER_PREFERENCE = ['iiif_image'] + BASE_PREFERENCE


I assume we don't use invenio-previewer anywhere?

Invenio-previewer is included in requirements.txt.

If I remember correctly HK run into an issue where invenio-previewer needs to be installed even if we don't use it.
-> Maybe some other invenio package functionality breaks (and as such B2SHARE breaks) if invenio-previewer is not installed. Maybe inveniosoftware forgot to include it as dependency to some package.

hjhsalo · 2021-03-15T13:26:38Z

b2share/config.py

+# https://flask-debugtoolbar.readthedocs.io/en/latest/#configuration
+
+#: Switches off incept of redirects by Flask-DebugToolbar.
+DEBUG_TB_INTERCEPT_REDIRECTS = False


HK: Probably from invenio-cookiecutter.

hjhsalo · 2021-03-15T13:27:23Z

b2share/config.py

+# Configures Content Security Policy for PDF Previewer
+# Remove it if you are not using PDF Previewer
+APP_DEFAULT_SECURE_HEADERS['content_security_policy'] = {
+    'default-src': ["'self'", "'unsafe-inline'"],
+    'object-src': ["'none'"],
+    'script-src': ["'self'", "'unsafe-inline'", "'unsafe-eval'"],
+    'style-src': ["'self'", "'unsafe-inline'", "data:", "https://fonts.googleapis.com/css"],
+    'img-src': ["'self'", "data: blob:;"],
+    'font-src': ["'self'", "data:", "https://fonts.gstatic.com", "https://fonts.googleapis.com"],
+}


HK: Despite the comment above, B2SHARE breaks if this is not set.
It is worthwhile to check how this could be either removed or restricted.

hjhsalo · 2021-03-15T13:30:11Z

b2share/config.py

+#: Endpoint for uploading files.
+DEPOSIT_FILES_API = u'/api/files'
+#: Template for deposit list view.
+DEPOSIT_SEARCH_API = '/api/deposit/depositions'
+#: Template for deposit records API.
+DEPOSIT_RECORDS_API = '/api/deposit/depositions/{pid_value}'
+#: Records REST API endpoints.
+RECORDS_API = '/api/records/{pid_value}'
+#: Default API endpoint for search UI.
+SEARCH_UI_SEARCH_API = "/api/records/"
+


HK: These might not be required.

HH: Might be related to first commits concerning flask_app building.

hjhsalo · 2021-03-15T13:32:31Z

b2share/config.py

+    consumer_key=os.environ.get("B2ACCESS_CONSUMER_KEY", '*** CONSUMER KEY ***'),
+    consumer_secret=os.environ.get("B2ACCESS_SECRET_KEY", '*** SECRET KEY ***'),


*** CONSUMER KEY *** and *** SECRET KEY *** are just placeholders. If not defined flask will complain that values have not been set.

hjhsalo · 2021-03-15T13:34:09Z

b2share/config.py

+CACHE_REDIS_URL=os.environ.get("INVENIO_CACHE_REDIS_URL", 'redis://localhost:6379/0')
+ACCOUNTS_SESSION_REDIS_URL = os.environ.get("INVENIO_ACCOUNTS_SESSION_REDIS_URL", 'redis://localhost:6379/1')


Should we default to one of these? What does invenio-accounts and invenio-cache documentation say?
Does Invenio-Accounts explicitly require this?

hjhsalo · 2021-03-15T13:36:57Z

b2share/config.py

@@ -423,6 +603,7 @@

 STATS_EVENTS = {
    'file-download': dict(
+        templates='invenio_stats.contrib.file_download',


Note that invenio-stats seems to have templates now.
Reference, documentation?

jupste · 2021-03-15T13:41:17Z

b2share/config.py

@@ -458,3 +639,13 @@
 #: There is no password so don't send password change emails
 SECURITY_SEND_PASSWORD_CHANGE_EMAIL=False
 SECURITY_SEND_PASSWORD_RESET_NOTICE_EMAIL=False
+
+# Extra (Harry Kodden)


If these are not set you will get browser errors

jupste · 2021-03-15T13:42:42Z

b2share/config.py

+SESSION_COOKIE_PATH="/"
+SESSION_COOKIE_SAMESITE="Lax"
+
+APP_THEME = ['semantic-ui']


Does this come from cookiecutter? Does it need to be changed at some point?

More info: https://invenio-app.readthedocs.io/en/latest/configuration.html#invenio_app.config.APP_THEME

jupste · 2021-03-15T13:44:11Z

b2share/config.py

+SESSION_COOKIE_SAMESITE="Lax"
+
+APP_THEME = ['semantic-ui']
+SECURITY_CHANGEABLE = False


Allows changing of password for invenio accounts. Can be ignored since we are using B2ACCESS for user validation

hjhsalo · 2021-03-15T13:52:06Z

b2share/config.py

+#: Use default frontpage.
+THEME_FRONTPAGE = True
+#: Frontpage title.
+THEME_FRONTPAGE_TITLE = _('B2SHARE')


Note the _ in front of B2SHARE. This needs to be defined like this for Babel / i18n

hjhsalo · 2021-03-15T13:53:47Z

b2share/config.py

+#: Frontpage title.
+THEME_FRONTPAGE_TITLE = _('B2SHARE')
+#: Frontpage template.
+THEME_FRONTPAGE_TEMPLATE = 'b2share_main/page.html'


This is essentially the B2SHARE V2 webui/app/index.html.
!! Build of webui and packaging with B2SHARE backend code needs to be adopted.
New Dockerfile addresses this.

jupste

WIP

hjhsalo · 2021-03-15T13:56:32Z

Dockerfile

+COPY webui/app b2share/modules/b2share_main/static
+
+RUN mv b2share/modules/b2share_main/static/index.html b2share/modules/b2share_main/templates/b2share_main/page.html


Note that these handle moving of webpack built app-folder to correct path in B2SHARE backend and renaming to index.html to b2share/modules/b2share_main/templates/b2share_main/page.html (See THEME_FRONTPAGE_TEMPLATE config.py for more info)

hjhsalo · 2021-03-15T13:58:34Z

b2share/config.py

+APP_ENABLE_SECURE_HEADERS = (os.environ.get('SESSION_COOKIE_SECURE', "True").upper() == "True".upper())
+
+SESSION_COOKIE_PATH="/"
+SESSION_COOKIE_SAMESITE="Lax"


SESSION_COOKIE_SAMESITE comes from Flask: https://flask.palletsprojects.com/en/1.1.x/config/#SESSION_COOKIE_SAMESITE

For more info on possible values see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite

hjhsalo · 2021-03-15T14:03:30Z

b2share/factory.py

+@app_created.connect
+def receiver_app_created(sender, app=None, **kwargs):
+    app.logger.debug("Application created")
+
+@app_loaded.connect
+def receiver_app_loaded(sender, app=None, **kwargs):
+    app.logger.debug("Application Loaded")
+    app.logger.debug("Instance Path: {}".format(app.instance_path))
+    check_configuration(app.config, app.logger)


Mostly logging but NOTE check_configuration is handled with signals now and not syncronously as with V2:

b2share/b2share/factory.py

Line 150 in d846068

check_configuration(api.config, api.logger)

hjhsalo · 2021-03-15T14:05:48Z

b2share/factory.py

+    Defaults to ``<env_prefix>_STATIC_FOLDER``
+    or if environment variable is not set ``<sys.prefix>/var/instance/static``.
+    """
+    return os.getenv(env_prefix + '_STATIC_FOLDER') or \
+        os.path.join(instance_path(), 'static')


V2 codebase uses B2SHARE_UI_PATH.

b2share/b2share/factory.py

Lines 133 to 135 in d846068

static_folder=os.environ.get(

'B2SHARE_UI_PATH',

os.path.join(api.instance_path, 'static')),

Might need to be changed, or not

hjhsalo · 2021-03-15T14:08:24Z

b2share/factory.py

+def config_loader(app, **kwargs_config):
+    """Configuration loader.
+
+    Adds support for loading templates from the Flask application's instance
+    folder (``<instance_folder>/templates``).
    """
-    # Create the REST API Flask application
-    api = create_api(**kwargs)
-    api.config.update(
-        APPLICATION_ROOT='/api'
+    # This is the only place customize the Flask application right after
+    # it has been created, but before all extensions etc are loaded.
+    local_templates_path = os.path.join(app.instance_path, 'theme/templates')
+    if os.path.exists(local_templates_path):
+        # Let's customize the template loader to look into packages
+        # and application templates folders.
+        app.jinja_loader = ChoiceLoader([
+            FileSystemLoader(local_templates_path),
+            app.jinja_loader,
+        ])
+
+    app.jinja_options = dict(
+        app.jinja_options,
+        cache_size=1000,
+        bytecode_cache=BytecodeCache(app)
    )


HK: Might not be used. Comes from cookiecutter. B2SHARE V2 has a very simple config_loader:

b2share/b2share/factory.py

Line 101 in d846068

config_loader = create_conf_loader(config=config, env_prefix=env_prefix)

Let's check if this can be removed?

jupste · 2021-03-22T14:27:30Z

docker-compose.full.yml

@@ -0,0 +1,161 @@
+# -*- coding: utf-8 -*-


This file is completely compatible with invenio cookie-cutter

jupste · 2021-03-22T14:31:00Z

docker/postgres/Dockerfile

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-


Is this needed or could we just use the image from dockerhub?

jupste · 2021-03-22T14:32:35Z

entry_points.txt

@@ -0,0 +1,91 @@
+[console_scripts]


This was previously in setup.py

jupste · 2021-03-22T14:43:40Z

tests/b2share_unit_tests/communities/test_communities_rest.py

@@ -241,7 +241,7 @@ def test_invalid_get(app, login_user,
            res = client.get(url_for('b2share_communities.communities_item',
                                     community_id=community_id),
                             headers=headers)
-            assert res.status_code == 406


This probably doesn't fix the underlying issue and needs to be reverted

jupste · 2021-03-22T14:46:37Z

tests/b2share_unit_tests/records/test_records_index.py

@@ -33,29 +33,35 @@
 from invenio_indexer.api import RecordIndexer
 from invenio_records.api import Record
 from b2share.modules.deposit.api import Deposit
-
+from time import sleep


flush method was not sufficient to refresh the indices

use wait_for_completion instead

jupste · 2021-03-22T14:47:29Z

tests/b2share_unit_tests/records/test_records_rest.py

@@ -27,7 +27,7 @@
 import copy

 from flask import url_for
-from b2share_unit_tests.helpers import (


Maybe this could be addressed with python path envar

jupste · 2021-03-22T14:50:47Z

tests/b2share_unit_tests/records/test_records_serializers.py

@@ -58,7 +58,7 @@ def test_records_serializers_dc(app, test_records_data):
    with app.app_context():
        pid, record = make_record(test_records_data)
        rec = {
-            '_source': RecordIndexer._prepare_record(
+            '_source': RecordIndexer()._prepare_record(


_prepare_record can not be invoked without having the parenthases with the RecordIndexer class

jupste · 2021-03-22T14:51:38Z

tests/b2share_unit_tests/upgrade/test_upgrade.py

@@ -156,7 +156,7 @@ def test_init_fail_and_retry(clean_app):
        # create a conflicting table.
        db.engine.execute('CREATE table b2share_community (wrong int);')
        result = upgrade_run(clean_app)
-        assert result.exit_code == -1
+        assert result.exit_code != 0


Maybe this should return -1?

jupste

Reviewed all the files

CHANGE: B2ShareRecordSearch to RecordSearch in searchy.py files Signed-off-by: Jussi Steenari <[email protected]>

…into v3-feature-branch Signed-off-by: Jussi Steenari <[email protected]> Conflicts: b2share/config.py

…str(uuid.uuid4())

Signed-off-by: Jussi Steenari <[email protected]>

…into v3-feature-branch

…es to upgrade tests Signed-off-by: Jussi Steenari <[email protected]>

…into v3-feature-branch

Feature branch for V3.0.0 started

f12fe9c

hjhsalo requested review from HarryKodden, hevp, jupste and noblespirit March 15, 2021 12:36

hjhsalo closed this Mar 15, 2021

Initial deposit

705c5bf

hjhsalo reopened this Mar 15, 2021

hjhsalo commented Mar 15, 2021

View reviewed changes

jupste reviewed Mar 15, 2021

View reviewed changes

hjhsalo commented Mar 15, 2021

View reviewed changes

jupste reviewed Mar 15, 2021

View reviewed changes

hjhsalo commented Mar 15, 2021

View reviewed changes

jupste reviewed Mar 22, 2021

View reviewed changes

docker-compose.full.yml

@@ -0,0 +1,161 @@

# -*- coding: utf-8 -*-

Copy link

Contributor

jupste Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is completely compatible with invenio cookie-cutter

jupste reviewed Mar 22, 2021

View reviewed changes

docker/postgres/Dockerfile

@@ -0,0 +1,9 @@

# -*- coding: utf-8 -*-

Copy link

Contributor

jupste Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or could we just use the image from dockerhub?

jupste reviewed Mar 22, 2021

View reviewed changes

entry_points.txt

@@ -0,0 +1,91 @@

[console_scripts]

Copy link

Contributor

jupste Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously in setup.py

jupste reviewed Mar 22, 2021

View reviewed changes

HarryKodden and others added 21 commits March 24, 2021 13:58

wip

6c8ca82

CHANGE: Permission to DynamicPermission in permission.py files

c0de60e

CHANGE: B2ShareRecordSearch to RecordSearch in searchy.py files Signed-off-by: Jussi Steenari <[email protected]>

Merge branch 'v3-feature-branch' of github.com:EUDAT-B2SHARE/b2share …

d2b09f6

…into v3-feature-branch Signed-off-by: Jussi Steenari <[email protected]> Conflicts: b2share/config.py

wip

d36f200

uuid.uuid4().hex should not be used, use str(uuid.uuid4()) instead.

eab20db

Pattern fix

dad4772

subclassing InvenioDeposit and adjust usage of uuid.uuid4().hex into …

38acbb2

…str(uuid.uuid4())

Reverting uuid.uui4d() back to uuid.uuid4().hex

3c5fe02

wip

5233d84

wip

a331d12

wip

81797d9

wip

84a92d5

CHANGE: http code assert in test_communities_rest

018d76c

Signed-off-by: Jussi Steenari <[email protected]>

Merge branch 'v3-feature-branch' of github.com:EUDAT-B2SHARE/b2share …

998400d

…into v3-feature-branch

wip

0a5acb5

Merge branch 'v3-feature-branch' of github.com:EUDAT-B2SHARE/b2share …

013f823

…into v3-feature-branch

wip

13c4ef5

Merge branch 'v3-feature-branch' of github.com:EUDAT-B2SHARE/b2share …

aec47ca

…into v3-feature-branch

final commit

b3e3179

MODIFY: commented out lines from b2share_db_load_data.sql. Made chang…

620b968

…es to upgrade tests Signed-off-by: Jussi Steenari <[email protected]>

Merge branch 'v3-feature-branch' of github.com:EUDAT-B2SHARE/b2share …

27d5057

…into v3-feature-branch

	FILES_REST_DEFAULT_MAX_FILE_SIZE = 10 * 1024 * 1024 * 1024 # 10 GB per file
	"""Maximum file size for the files in a record"""

	FILES_REST_DEFAULT_QUOTA_SIZE = 20 * 1024 * 1024 * 1024 # 20 GB per record

		consumer_key=os.environ.get("B2ACCESS_CONSUMER_KEY", '* CONSUMER KEY *'),
		consumer_secret=os.environ.get("B2ACCESS_SECRET_KEY", '* SECRET KEY *'),

		CACHE_REDIS_URL=os.environ.get("INVENIO_CACHE_REDIS_URL", 'redis://localhost:6379/0')
		ACCOUNTS_SESSION_REDIS_URL = os.environ.get("INVENIO_ACCOUNTS_SESSION_REDIS_URL", 'redis://localhost:6379/1')

		COPY webui/app b2share/modules/b2share_main/static

		RUN mv b2share/modules/b2share_main/static/index.html b2share/modules/b2share_main/templates/b2share_main/page.html

	static_folder=os.environ.get(
	'B2SHARE_UI_PATH',
	os.path.join(api.instance_path, 'static')),

Review of V3.0.0 changes #1842

Are you sure you want to change the base?

Review of V3.0.0 changes #1842

Conversation

hjhsalo commented Mar 15, 2021 • edited Loading

hjhsalo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jupste left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhsalo Mar 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jupste left a comment

Choose a reason for hiding this comment

hjhsalo commented Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading

hjhsalo Mar 15, 2021 •

edited

Loading