-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pre-commit config #63
add pre-commit config #63
Conversation
I had a quick look at adding
but that fails with
In any case, this is likely to fail on a bare repo anyway, as the types are only available after generation. |
I have no idea if changes are required in the devcontainer. |
Currently using Ubuntu 22.04 version
Are settings in https://github.com/ETSInitiative/PETSIRD/blob/main/.devcontainer/devcontainer.json independent of this? (That'd be a pain). (Possibly also relevant microsoft/vscode-python#10165) |
Once done, I suggest we use https://pre-commit.ci/ |
Copied from https://github.com/SyneRBI/PETRIC/blob/main/.pre-commit-config.yaml, but deleted
mypy
as yardl generates files that throw up errors with mypy and is using pyright instead.Obviously, this will change formatting in various files, which we'll need to commit.